Don't consider Union to always be a type alias
#8489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielNoord
added
False Positive π¦
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #8489 +/- ##
=======================================
Coverage 95.81% 95.81%
=======================================
Files 174 174
Lines 18333 18334 +1
=======================================
+ Hits 17566 17567 +1
Misses 767 767
|
Co-authored-by: Pierre Sassoulas <[email protected]>
Pierre-Sassoulas
approved these changes
Mar 23, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Mar 23, 2023
Co-authored-by: Pierre Sassoulas <[email protected]> (cherry picked from commit 07127ee)
|
π€ According to the primer, this change has no effect on the checked open source code. π€π This comment was generated for commit e53297a |
DanielNoord
added a commit
that referenced
this pull request
Mar 23, 2023
Co-authored-by: Pierre Sassoulas <[email protected]> (cherry picked from commit 07127ee)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Closes #8487.
Silly mistake in this logic.