Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI errors in statspace test suite #251

Merged
merged 12 commits into from
Oct 8, 2023

Conversation

jessegrabowski
Copy link
Member

@jessegrabowski jessegrabowski commented Oct 7, 2023

The statsmodels import in the statespace tests are causing everyone's CI to break. This PR fixes that.

- Squeeze result vector-matrix multiplication with (1, 1) matrix to avoid shape error in numpy 1.25.2
@jessegrabowski
Copy link
Member Author

jessegrabowski commented Oct 7, 2023

@ricardoV94 can you look at how I wrote the ignore statement in setup.cfg and see if you understand why it's not working?

I think the settings files for pymc-experimental need to be consolidated -- we have a pyproject.toml, pytest.ini, and setup.cfg, and all of them have pytest flags inside. I guess only pytest.ini is actually used, though.

@twiecki twiecki mentioned this pull request Oct 8, 2023
@jessegrabowski
Copy link
Member Author

jessegrabowski commented Oct 8, 2023

Down to one error, but it's in pymc.sampling.jax. This line:

    postprocessing_backend: Literal["cpu", "gpu"] | None = None,

Is not 3.9 compatible (the pipe union operator for type hints was added in 3.10).

We can either skip the test here, or patch it on the pymc side. Thoughts @twiecki @ricardoV94 ?

@twiecki
Copy link
Member

twiecki commented Oct 8, 2023

@jessegrabowski Let's xfail it here, merge, and fix it on pymc.

…c.sampling.jax

Skip pathfinder test if python < 3.10

Add some comments to `pyproject.toml` to explain what warnings are being ignored and why
@jessegrabowski
Copy link
Member Author

Looks like there's already a patch in the works here: pymc-devs/pymc#6944

@jessegrabowski jessegrabowski requested a review from twiecki October 8, 2023 15:09
@jessegrabowski
Copy link
Member Author

Make sure those config files I removed weren't there for some other reason (related to building for instance). They seemed to just have pytest and pre-commit settings that were being ignored anyway

@twiecki
Copy link
Member

twiecki commented Oct 8, 2023

You can test that by running python setup.py sdist

@jessegrabowski
Copy link
Member Author

Worked fine, I'm merging this.

@jessegrabowski jessegrabowski merged commit e163a6f into pymc-devs:main Oct 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants