-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix type hints Python 3.9 compatibility #6944
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6944 +/- ##
==========================================
- Coverage 90.69% 85.17% -5.53%
==========================================
Files 100 100
Lines 16833 16833
==========================================
- Hits 15267 14337 -930
- Misses 1566 2496 +930
|
Should we run pre-commit on the oldest supported python version? Would that have caught the problem? |
Sounds like we just need a |
Looks like we're running pre-commit multiple times then, and here it's already under Python 3.9: pymc/.github/workflows/pre-commit.yml Line 31 in 602234b
|
also this error again. It shouldn't be our job to pin |
That's just the mypy job which apparently didn't pick the incompatible type hints. I think the pre-commit itself would have |
Is that in our CI? |
closing in favor of #6945 to which I cherry-picked the commit |
What is this PR about?
Trying to fix one of the reasons why our CIs are going β.
Closes #6941
Checklist
Literal | None
doesn't work in Python 3.9Bugfixes
jax
submodule under Python 3.9π Documentation preview π: https://pymc--6944.org.readthedocs.build/en/6944/