yxy rotation

[rapidnico]

added yxy rotation to Rotation.toEulerAngles

---

This change is 

[pariterre]

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @rapidnico)

---

src/Utils/Rotation.cpp line 254 at r1 (raw file):

        v[0] = std::atan2(r(0,1), r(2,1));   // y
        v[1] = std::asin(r(1,1));            // x
        v[2] = std::atan2(-r(1,0), r(1,2));  // y

Where did you take these? It does not correspond to the ref at the beggining of the section

Code quote:

        v[0] = std::atan2(r(0,1), r(2,1));   // y
        v[1] = std::asin(r(1,1));            // x
        v[2] = std::atan2(-r(1,0), r(1,2));  // y

[rapidnico]

Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @pariterre)

---

src/Utils/Rotation.cpp line 254 at r1 (raw file):

Previously, pariterre (Pariterre) wrote…

Where did you take these? It does not correspond to the ref at the beggining of the section

Done

---

src/Utils/Rotation.cpp line 255 at r1 (raw file):

   v[0] = std::atan2(r(0,1), r(2,1));   // y
    v[1] = std::asin(r(1,1));            // x
    v[2] = std::atan2(-r(1,0), r(1,2));  // y

[pariterre]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion