Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Python 3.3 jobs on Travis. #117

Conversation

GabrielC101
Copy link

@GabrielC101 GabrielC101 commented Dec 11, 2017

As @benoit-pierre mentioned in pypa/pip#4897, the most current version of pytest no longer supports Python 3.3. This causes Travis to fail.

This PR applies a fix similar to the one used in pypa/pip#4897.

… causes Travis builds to fail. Fix this by requiring tox to use pytest 3.2.5 or less.
@GabrielC101
Copy link
Author

Could someone review/approve this? It's urgent, but uncontroversial.

@hugovk
Copy link
Contributor

hugovk commented Dec 21, 2017

Pytest dropped a Python 3.3 as it's EOL, no longer receiving security updates, and is generally little used (see pypa/pip#3796 for 1+ year old numbers).

Does this library still need to support 3.3? How about just dropping it, or at the very least deprecating it?

@GabrielC101
Copy link
Author

GabrielC101 commented Dec 27, 2017

Pulling support for python3.3 is an option . . . but another approach is to stop testing for python3.3 in tox /travis, but allow python3.3 in a "use at your own risk capacity."

In other words, change tox.ini and .travis.yml, but leave setup.py alone.

In fact, now that I look at it, the only reference to Python version in setup.py is in the classifiers.

So what does "supporting" python3.3 mean?

@hugovk
Copy link
Contributor

hugovk commented Feb 28, 2018

This can be closed now #118 is merged.

@dstufft dstufft closed this Feb 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants