Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Python 3.3 jobs on AppVeyor/Travis #4897

Merged
merged 1 commit into from
Dec 1, 2017
Merged

Fix Python 3.3 jobs on AppVeyor/Travis #4897

merged 1 commit into from
Dec 1, 2017

Conversation

benoit-pierre
Copy link
Member

@dstufft dstufft added the skip news Does not need a NEWS file entry (eg: trivial changes) label Nov 30, 2017
pradyunsg
pradyunsg approved these changes Nov 30, 2017
View reviewed changes
Copy link
Member

@pradyunsg pradyunsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @benoit-pierre!

dev-requirements.txt
@@ -1,6 +1,6 @@
freezegun
pretend
pytest
pytest<=3.2.5
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just < 3.3.0 would be kinda more correct but it has no actual practical difference unless pytest has another release in the 3.2 series.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More prudent maybe? :P

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed.

TIL - prudent. :)

@pradyunsg pradyunsg added C: automation Automated checks, CI etc type: maintenance Related to Development and Maintenance Processes labels Nov 30, 2017
@pradyunsg
Copy link
Member

I guess I'll merge this in the morning (8+ hours) if someone doesn't raise an issue with this PR by then. 🤷‍♂️

@GabrielC101 GabrielC101 mentioned this pull request Dec 1, 2017
Merged
@pradyunsg pradyunsg merged commit fc6b2c1 into pypa:master Dec 1, 2017
@benoit-pierre benoit-pierre deleted the fix_cis_py33_jobs branch December 4, 2017 18:46
@GabrielC101 GabrielC101 mentioned this pull request Dec 11, 2017
Closed
@lock
Copy link

lock bot commented Jun 2, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Jun 2, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jun 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pradyunsg pradyunsg pradyunsg approved these changes

Assignees
No one assigned
Labels
auto-locked Outdated issues that have been locked by automation C: automation Automated checks, CI etc skip news Does not need a NEWS file entry (eg: trivial changes) type: maintenance Related to Development and Maintenance Processes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benoit-pierre @pradyunsg @dstufft