Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define untyped defs in pip._internal.wheel #7107

Merged
merged 1 commit into from
Oct 30, 2019
Merged

Define untyped defs in pip._internal.wheel #7107

merged 1 commit into from
Oct 30, 2019

Conversation

mkurnikov
Copy link
Contributor

Based on #7105

@mkurnikov
Copy link
Contributor Author

mkurnikov commented Sep 28, 2019 •
edited
Loading

@pradyunsg If you approve/merge those two PRs, I can add others today too.

@mkurnikov mkurnikov force-pushed the disallow-untyped-defs-wheel branch from f254899 to 36744d0 Compare September 28, 2019 15:32
@pradyunsg
Copy link
Member

@mkurnikov Hi, thanks!

Would it be possible for you to make a single PR adding disallow-untyped-defs=True in the mypy.ini and add disallow-untyped-defs=False comments for files that fail the check? Then we can just start removing those comments.

@mkurnikov
Copy link
Contributor Author

Sure, it makes sense, here it is #7109

@BrownTruck
Copy link
Contributor

Hello!

I am an automated bot and I have noticed that this pull request is not currently able to be merged. If you are able to either merge the master branch into this pull request or rebase this pull request against master then it will be eligible for code review and hopefully merging!

@BrownTruck BrownTruck added the needs rebase or merge PR has conflicts with current master label Sep 30, 2019
@chrahunt chrahunt force-pushed the disallow-untyped-defs-wheel branch from 36744d0 to c1edc11 Compare October 20, 2019 13:32
@pypa-bot pypa-bot removed the needs rebase or merge PR has conflicts with current master label Oct 20, 2019
@chrahunt chrahunt added skip news Does not need a NEWS file entry (eg: trivial changes) type: maintenance Related to Development and Maintenance Processes labels Oct 20, 2019
@chrahunt chrahunt force-pushed the disallow-untyped-defs-wheel branch from c1edc11 to 92e690d Compare October 20, 2019 13:33
@chrahunt
Copy link
Member

Rebased on master.

chrahunt
chrahunt reviewed Oct 21, 2019
View reviewed changes
src/pip/_internal/wheel.py Outdated Show resolved Hide resolved
src/pip/_internal/wheel.py Outdated Show resolved Hide resolved
@chrahunt chrahunt changed the title set disallow_untyped_defs=True for pip._internal.wheel Define untyped defs in pip._internal.wheel Oct 21, 2019
@pradyunsg
Copy link
Member

@chrahunt since @mkurnikov seems to be out sick (get well soon!), would you be OK merging this as is, or even pushing the relevant fixes to their branch?

@chrahunt chrahunt force-pushed the disallow-untyped-defs-wheel branch from 92e690d to 3d3f663 Compare October 29, 2019 22:29
@chrahunt
Copy link
Member

Done!

@pradyunsg pradyunsg merged commit 644ff6c into pypa:master Oct 30, 2019
@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Nov 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Nov 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chrahunt chrahunt chrahunt approved these changes

Assignees
No one assigned
Labels
auto-locked Outdated issues that have been locked by automation skip news Does not need a NEWS file entry (eg: trivial changes) type: maintenance Related to Development and Maintenance Processes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mkurnikov @pradyunsg @BrownTruck @chrahunt @pypa-bot