Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to mypy==0.730 #7105

Merged
merged 1 commit into from
Sep 29, 2019
Merged

Update to mypy==0.730 #7105

merged 1 commit into from
Sep 29, 2019

Conversation

mkurnikov
Copy link
Contributor

No description provided.

@pradyunsg
Copy link
Member

pradyunsg commented Sep 28, 2019

Thanks for filing this PR!

The mypy.txt file has to be deleted (it's no longer used). We switched to pre-commit in #7078 and it seems like I've missed deleting that file. You'd want to update the version in .pre-commit-config.yaml. :)

@pradyunsg pradyunsg mentioned this pull request Sep 28, 2019
@mkurnikov
Copy link
Contributor Author

Got it.

Is it ok, if I use # noqa: F821 for now?

./src/pip/_internal/utils/appdirs.py:230:78: F821 undefined name 'ignore'
./src/pip/_internal/utils/appdirs.py:230:78: F821 undefined name 'attr'
./src/pip/_internal/utils/appdirs.py:230:78: F821 undefined name 'defined'

@mkurnikov
Copy link
Contributor Author

Actually, there's no way I can fit this line into 80 chars limit, without pretty nasty indentation, any recommendations on how to do it better?

@pradyunsg
Copy link
Member

func = ctypes.windll.kernel32.GetShortPathNameW?

I mean, I don't like it either but I can't think of anything better. :)

@mkurnikov
Copy link
Contributor Author

@pradyunsg Found a better way, and with that, error codes won't make much difference, so no noqa: F821 required.

@pradyunsg pradyunsg added skip news Does not need a NEWS file entry (eg: trivial changes) type: maintenance Related to Development and Maintenance Processes labels Sep 28, 2019
@pradyunsg pradyunsg merged commit 716afdb into pypa:master Sep 29, 2019
@mkurnikov mkurnikov deleted the mypy-730 branch September 29, 2019 10:00
@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Oct 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto-locked Outdated issues that have been locked by automation skip news Does not need a NEWS file entry (eg: trivial changes) type: maintenance Related to Development and Maintenance Processes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants