Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove disallow_untyped_defs=False for index.collector #7108

Merged
merged 1 commit into from
Nov 16, 2019
Merged

Remove disallow_untyped_defs=False for index.collector #7108

merged 1 commit into from
Nov 16, 2019

Conversation

mkurnikov
Copy link
Contributor

Based on #7105

@mkurnikov mkurnikov changed the title add disallow_untyped_defs=True for pip._internal.collector set disallow_untyped_defs=True for pip._internal.collector Sep 28, 2019
@xavfernandez xavfernandez added the skip news Does not need a NEWS file entry (eg: trivial changes) label Sep 29, 2019
@mkurnikov mkurnikov force-pushed the disallow-untyped-defs-collector branch from 7428967 to 5554aae Compare September 29, 2019 21:48
@mkurnikov mkurnikov mentioned this pull request Sep 29, 2019
Merged
@BrownTruck
Copy link
Contributor

Hello!

I am an automated bot and I have noticed that this pull request is not currently able to be merged. If you are able to either merge the master branch into this pull request or rebase this pull request against master then it will be eligible for code review and hopefully merging!

@BrownTruck BrownTruck added the needs rebase or merge PR has conflicts with current master label Sep 30, 2019
@mkurnikov mkurnikov force-pushed the disallow-untyped-defs-collector branch from 5554aae to 93fc2b9 Compare November 14, 2019 16:44
@pypa-bot pypa-bot removed the needs rebase or merge PR has conflicts with current master label Nov 14, 2019
@mkurnikov
Copy link
Contributor Author

@pradyunsg Rebased, should be ready for review.

pradyunsg
pradyunsg requested changes Nov 14, 2019
View reviewed changes
src/pip/_internal/index/collector.py Outdated Show resolved Hide resolved
@pradyunsg pradyunsg added the type: maintenance Related to Development and Maintenance Processes label Nov 14, 2019
@pradyunsg pradyunsg changed the title set disallow_untyped_defs=True for pip._internal.collector Remove disallow_untyped_defs=False for index.collector Nov 14, 2019
@mkurnikov mkurnikov force-pushed the disallow-untyped-defs-collector branch 2 times, most recently from a2c3513 to 6673b18 Compare November 16, 2019 13:52
@mkurnikov mkurnikov force-pushed the disallow-untyped-defs-collector branch from 6673b18 to e9fcd75 Compare November 16, 2019 13:53
@pradyunsg pradyunsg merged commit 7ae58b5 into pypa:master Nov 16, 2019
@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Dec 16, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Dec 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@xavfernandez xavfernandez xavfernandez left review comments

@pradyunsg pradyunsg pradyunsg requested changes

Assignees
No one assigned
Labels
auto-locked Outdated issues that have been locked by automation skip news Does not need a NEWS file entry (eg: trivial changes) type: maintenance Related to Development and Maintenance Processes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mkurnikov @BrownTruck @xavfernandez @pradyunsg @pypa-bot