Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--pre per–package #1696

Closed
gsemet opened this issue Mar 13, 2018 · 9 comments
Closed

--pre per–package #1696

gsemet opened this issue Mar 13, 2018 · 9 comments
Labels
Type: Enhancement 💡 This is a feature or enhancement request.

Comments

@gsemet
Copy link
Contributor

gsemet commented Mar 13, 2018

This is a follow up on #1677.

pipenv lock doesn't work because I need a preversion of a single package. pipenv lock --pre does work but might add other, unwanted preversion in dependencies.

I would like to propose my help in implementing this feature: if one package needs to be frozen to a preversion (and only one), allow the dependency finding to pick this one even without the --pre parameter.

The --pre parameter which the preversion search for all packages, and sometimes we only want one package

@kennethreitz kennethreitz added the Type: Enhancement 💡 This is a feature or enhancement request. label Mar 13, 2018
@kennethreitz kennethreitz changed the title Support freezing a preversion in Pipfile for a package pre per–package Mar 13, 2018
@kennethreitz
Copy link
Contributor

This would be nice, but is not feasible (as far as I know) with the way our current resolver code works. It's either "all or nothing".

@techalchemy
Copy link
Member

But if you know you want a specific package to be prerelease then you probably know what version, so (once we get the strict pinning bug sorted) you should be able to just pin the prerelease

@kennethreitz kennethreitz changed the title pre per–package --pre per–package Mar 13, 2018
@kennethreitz
Copy link
Contributor

+1, closing for that solution, for now. Our resolver just doesn't allow this yet.

@kennethreitz
Copy link
Contributor

Thanks for the suggestion, though!

@gsemet
Copy link
Contributor Author

gsemet commented Mar 13, 2018

Hello @techalchemy If you reread my bug, this pinning of the release does not work if there are 2 packages describing the same dependency, where one says "a==1.0" and the other says "a>=1.0"; of course when the resolution is obvious but a human being (especially because the list after containst this very version)
When all packages says it wish "a==1.0", yes, pinning works.

@kennethreitz
Copy link
Contributor

please see #1687

@gsemet
Copy link
Contributor Author

gsemet commented Mar 13, 2018

indeed, same issue

gsemet added a commit to gsemet/pipenv that referenced this issue Mar 13, 2018
gsemet added a commit to gsemet/pipenv that referenced this issue Mar 14, 2018
gsemet added a commit to gsemet/pipenv that referenced this issue Mar 31, 2018
@tribals
Copy link

tribals commented Jan 28, 2019

Well, I think, if the problem in resolver, there is need to replace it.

@tribals
Copy link

tribals commented Jan 28, 2019

And not reject any issues just with "our resolver can't do that".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement 💡 This is a feature or enhancement request.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants