cover double dependency on a prerelease (work in progress) #1732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsemet
force-pushed
the
pinned_preversion
branch
from
efd6339 to
a25cfa7
Compare
gsemet
commented
Mar 14, 2018
tests/test_pipenv.py
Outdated
| transitive_pkg_version = '>=1.1.0rc1' | ||
| c = p.pipenv('install {0}{1}'.format(target_package, preversion)) | ||
| assert c.return_code == 0 | ||
| c = p.pipenv('install {0}{1}'.format(transitive_pkg_name, transitive_pkg_version)) |
There was a problem hiding this comment.
this fails for the moment. I'm looking for a way of making it work
|
thank you for contributing actual code! |
|
✨🍰✨ |
|
this stuff is super tricky — don't pull your hair out trying to figure it out :) |
|
I would be glad to have some help :) |
|
If you want to hop on a Google Hangouts, let me know! |
Fix pypa#1696 Fix pypa#1687 Reference pypa#1693 Signed-off-by: Gaetan Semet <[email protected]>
gsemet
force-pushed
the
pinned_preversion
branch
from
42915b9 to
b2c777f
Compare
kennethreitz
changed the title
kennethreitz
requested changes
May 23, 2018
| @@ -455,7 +455,7 @@ def _check_skip_installed(self, req_to_install, finder): | |||
| elif self.upgrade_strategy == "only-if-needed": | |||
| skip_reason = 'not upgraded as not directly required' | |||
| else: | |||
| skip_reason = 'already satisfied' | |||
| skip_reason = 'already satisfied123' | |||
|
closing due to inactivity |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress. This PR adds a unit test covering the case where a dependency and a transitive dependency both want a prerelease version of the same package.
When both use the pin (
==) operator, it works, where one use a>=operator, an error occurs:I would like to find where the two dependency are retrieved, along with their operator. I would like to add an evaluation "is the resolution not yet done for this dependency", before starting the whole "search for the best package" resolver (in pip module)
Fix #1696
Fix #1687
Reference #1693
Signed-off-by: Gaetan Semet [email protected]