Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a warning for calling inverse of a non-bijective transform #1269

Merged
merged 3 commits into from
Jan 2, 2022
Merged

Add a warning for calling inverse of a non-bijective transform #1269

merged 3 commits into from
Jan 2, 2022

Conversation

fehiepsi
Copy link
Member

@fehiepsi fehiepsi commented Jan 1, 2022

Resolves #1253

This PR also includes a couple of small doc fixes.

@fehiepsi fehiepsi requested a review from OlaRonning January 1, 2022 17:40
OlaRonning
OlaRonning previously approved these changes Jan 1, 2022
View reviewed changes
Copy link
Member

@OlaRonning OlaRonning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @fehiepsi, LGTM.

@MarcoGorelli MarcoGorelli mentioned this pull request Jan 1, 2022
Merged
@fehiepsi fehiepsi requested a review from OlaRonning January 1, 2022 23:18
OlaRonning
OlaRonning approved these changes Jan 1, 2022
View reviewed changes
Copy link
Member

@OlaRonning OlaRonning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MarcoGorelli nice catch, thanks! @fehiepsi looks good.

@fehiepsi
Copy link
Member Author

fehiepsi commented Jan 2, 2022

Thanks for reviewing, @OlaRonning and @MarcoGorelli!

@fehiepsi fehiepsi merged commit fd99ec5 into pyro-ppl:master Jan 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcoGorelli MarcoGorelli MarcoGorelli left review comments

@OlaRonning OlaRonning OlaRonning approved these changes

Assignees
No one assigned
Labels
awaiting review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Raise an exception (or warning) when calling the inverse of a non-invertible transform.
3 participants
@fehiepsi @OlaRonning @MarcoGorelli