add stacklevel to warnings #1271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
force-pushed
the
add-stacklevel-to-warnings
branch
from
4731ad3 to
0b316d4
Compare
fehiepsi
approved these changes
Jan 1, 2022
There was a problem hiding this comment.
I'm not sure what's the common practice here but the changes look good to me - it seems to be better to raise the warning at the user-level code. Thanks, @MarcoGorelli!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref #1269 (comment)
This is so that warnings reference the line in the user's code where the warning is emitted, rather than the line of code internal to NumPyro (this way users know what they need to change)