Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show fullname on direct Node construction warning #9066

Merged
merged 2 commits into from
Oct 5, 2021

Conversation

eamanu
Copy link
Contributor

@eamanu eamanu commented Sep 1, 2021

This commit add the fullname on the Node construction warning.
Also add a test for this case.

closes #8994

This commit add the fullname on the Node construction warning.
Also add a test for this case.
Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks a lot @eamanu!

Couple of small things before we can merge:

  • Include a small changelog entry, in changelog/8994.improvement.rst:

    Included the module of the class in the error message about direct
    node construction (without using ``from_parent``).
  • Please add yourself to the AUTHORS file

Thanks!

@eamanu
Copy link
Contributor Author

eamanu commented Sep 2, 2021

Hello @nicoddemus,

Thanks for the review. I added the changelog file.

I'm already in AUTHORS file :-)

@nicoddemus
Copy link
Member

I'm already in AUTHORS file :-)

Ahh sorry, did not actually check. 😁

LGTM, thanks!

@nicoddemus nicoddemus merged commit 9546fb7 into pytest-dev:main Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show full qualified name on direct Node construction warning
3 participants