Show full qualified name on direct Node construction warning

[nicoddemus]

In ESSS/pytest-regressions#64, running pytest with many plugins installed gives this error:

Direct construction of SpecModule has been deprecated, please use SpecModule.from_parent.
See https://docs.pytest.org/en/stable/deprecations.html#node-construction-changed-to-node-from-parent for more details.

And is not clear which plugin is the culprit, I had to look at the source code of pytest-relaxed to figure it out.

We might consider at least show the full qualified name of the offending class in that message, so users would see pytest_relaxed.plugin.SpecModule, which is a nudge in the right direction.

Originally posted by @nicoddemus in #8993 (comment)

[eamanu]

Hi! I would like to work in this issue :)

[nicoddemus]

@eamanu thanks for volunteering! Please go ahead and let us know if you encounter any problems. 👍

[wassafshahzad]

Hi can I work on this as well ?

[eamanu]

Hi, @wassafshahzad sure!! I looked into the pytest code to identify where that message is write. That is here [0], I spend several time trying to found where the name is "loaded" into a class that use the NodeMeta. But I cannot found nothing yet. So, I'm trying to access to the Node class [1] variables from NodeMeta, and I guess that we'll need to use inspect to get the "path" to the bad initialize class.

[0]

pytest/src/_pytest/nodes.py

Line 122 in 6247a95

"Direct construction of {name} has been deprecated, please use {name}.from_parent.\n"

[1]

pytest/src/_pytest/nodes.py

Line 146 in 6247a95

class Node(metaclass=NodeMeta):

[nicoddemus]

Hi @eamanu @wassafshahzad,

Classes have a __module__ attribute which contain exactly the string we need:

>>> from _pytest.nodes import File
>>> File.__module__
'_pytest.nodes'

So unless I'm missing something it is just a matter of changing:

pytest/src/_pytest/nodes.py

Line 126 in 6247a95

).format(name=self.__name__)

To:

).format(name=f"{self.__module__}.{self.__name__}")

[wassafshahzad]

Hi @eamanu @wassafshahzad,

Classes have a __module__ attribute which contain exactly the string we need:

>>> from _pytest.nodes import File
>>> File.__module__
'_pytest.nodes'

So unless I'm missing something it is just a matter of changing:

pytest/src/_pytest/nodes.py

Line 126 in 6247a95

).format(name=self.__name__)

To:

).format(name=f"{self.__module__}.{self.__name__}")

so should we create a PR with this change ?

[nicoddemus]

Yes pretty much. 😁

Make sure to add/update an existing test for the new behavior too.

[eamanu]

I'm just create the PR, thanks @nicoddemus for the advice, was simpler that I imagine :)