Missing return for link.is_wheel==True

[Anselmoo]

• I am on the latest Poetry version.
• I have searched the issues of this repo and believe that this is not a duplicate.

• OS version and name: macOS:latest
• Poetry version: 1.1.12
• Link of a Gist with the contents of your pyproject.toml file:

Issue

According to PR #4962, there is the question left, if pass should not be replaced by a return. This would be also consistent with the typing definition Optional[Link].

poetry/src/poetry/installation/chef.py

Lines 44 to 47 in 1aa4d5b

	def get_cached_archive_for_link(self, link: Link) -> Optional[Link]:
	# If the archive is already a wheel, there is no need to cache it.
	if link.is_wheel:
	pass

At the moment

archives = self.get_cached_archives_for_link(link)

will be always excetuded.

[Anselmoo]

@finswimmer issue is assigend

[finswimmer]

Thanks @Anselmoo 👍 I've asked the other maintainers to have a look onto the PR, because I cannot estimate the impact of this change (Even if I guess it's correct).

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.