-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ideas for refactoring #4962
Ideas for refactoring #4962
Conversation
And also refering to issue python-poetry#4961
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot and a happy new year 👍
I just add some small suggestions and one questions.
I wonder how you find the parts to refactor?
Thank you @finswimmer! Wish you also a pleasant year. Concerning the general question, about how to find the reactors.
|
Removed items() from os.environ and add blank lines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes added
Thanks a lot 👍 Could you open an issue about this |
I will do! Thx for Your support |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
I saw that there
Refactor
-label, so I took a closer look and had the following suggestions.And also referring to issue #4961
Pull Request Check List
Resolves: #issue-number-here