Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-113299: Create libclinic package #113309

Closed
wants to merge 1 commit into from
Closed

gh-113299: Create libclinic package #113309

wants to merge 1 commit into from

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Dec 20, 2023 •
edited by bedevere-app bot
Loading

  • Create Tools/clinic/libclinic/ package.
  • Move cpp.py to libclinic.
  • Create libclinic.utils.

@vstinner
pythongh-113299: Create libclinic package
b58b260 
* Create Tools/clinic/libclinic/ package.
* Move cpp.py to libclinic.
* Create libclinic.utils.
@bedevere-app bedevere-app bot mentioned this pull request Dec 20, 2023
Closed
@vstinner
Copy link
Member Author

@erlend-aasland @AlexWaygood @corona10: Ok, here is first minimum step to create a new package for Argument Clinic code.

AlexWaygood
AlexWaygood reviewed Dec 20, 2023
View reviewed changes
Tools/clinic/libclinic/utils.py


# Clinic instance
clinic: 'Clinic' | None = None
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR feels like it only does my least favourite thing about your other PR :// #113299 (comment)

erlend-aasland
erlend-aasland reviewed Dec 20, 2023
View reviewed changes
Tools/clinic/clinic.py
@@ -2681,6 +2613,7 @@ def __init__(

global clinic
clinic = self
utils.clinic = self
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, putting a global from one file into another file is not a good idea.

@vstinner
Copy link
Member Author

@erlend-aasland:

IMO, putting a global from one file into another file is not a good idea.

I don't have the bandwidth right now to move this global variable. Adding utils.clinic variable is a temporary solution until someone can spend time to work on it. I gave on my latest attempt to partially fix the issue since nobody was available to review my work: #110984

Apparently, it's a requirement for @AlexWaygood and @erlend-aasland so I prefer to close this PR for now.

@vstinner vstinner closed this Dec 20, 2023
@erlend-aasland erlend-aasland mentioned this pull request Dec 20, 2023
Closed
@vstinner vstinner deleted the libclinic_converters branch December 20, 2023 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexWaygood AlexWaygood AlexWaygood left review comments

@erlend-aasland erlend-aasland erlend-aasland left review comments

Assignees
No one assigned
Labels
awaiting core review skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vstinner @erlend-aasland @AlexWaygood