-
-
Notifications
You must be signed in to change notification settings - Fork 30.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-113299: Create libclinic package #113309
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty file.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,87 @@ | ||
from __future__ import annotations | ||
|
||
import dataclasses as dc | ||
from typing import ( | ||
Literal, | ||
NoReturn, | ||
overload, | ||
TYPE_CHECKING, | ||
) | ||
|
||
if TYPE_CHECKING: | ||
from clinic import Clinic | ||
|
||
|
||
# Clinic instance | ||
clinic: 'Clinic' | None = None | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This PR feels like it only does my least favourite thing about your other PR :// #113299 (comment) |
||
|
||
|
||
@dc.dataclass | ||
class ClinicError(Exception): | ||
message: str | ||
_: dc.KW_ONLY | ||
lineno: int | None = None | ||
filename: str | None = None | ||
|
||
def __post_init__(self) -> None: | ||
super().__init__(self.message) | ||
|
||
def report(self, *, warn_only: bool = False) -> str: | ||
msg = "Warning" if warn_only else "Error" | ||
if self.filename is not None: | ||
msg += f" in file {self.filename!r}" | ||
if self.lineno is not None: | ||
msg += f" on line {self.lineno}" | ||
msg += ":\n" | ||
msg += f"{self.message}\n" | ||
return msg | ||
|
||
|
||
@overload | ||
def warn_or_fail( | ||
*args: object, | ||
fail: Literal[True], | ||
filename: str | None = None, | ||
line_number: int | None = None, | ||
) -> NoReturn: ... | ||
|
||
@overload | ||
def warn_or_fail( | ||
*args: object, | ||
fail: Literal[False] = False, | ||
filename: str | None = None, | ||
line_number: int | None = None, | ||
) -> None: ... | ||
|
||
def warn_or_fail( | ||
*args: object, | ||
fail: bool = False, | ||
filename: str | None = None, | ||
line_number: int | None = None, | ||
) -> None: | ||
joined = " ".join([str(a) for a in args]) | ||
if clinic: | ||
if filename is None: | ||
filename = clinic.filename | ||
if getattr(clinic, 'block_parser', None) and (line_number is None): | ||
line_number = clinic.block_parser.line_number | ||
error = ClinicError(joined, filename=filename, lineno=line_number) | ||
if fail: | ||
raise error | ||
else: | ||
print(error.report(warn_only=True)) | ||
|
||
|
||
def warn( | ||
*args: object, | ||
filename: str | None = None, | ||
line_number: int | None = None, | ||
) -> None: | ||
return warn_or_fail(*args, filename=filename, line_number=line_number, fail=False) | ||
|
||
def fail( | ||
*args: object, | ||
filename: str | None = None, | ||
line_number: int | None = None, | ||
) -> NoReturn: | ||
warn_or_fail(*args, filename=filename, line_number=line_number, fail=True) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO, putting a global from one file into another file is not a good idea.