bpo-29553: Fixed ArgumentParses format_usage for mutually exclusive groups #117

andrewnester · 2017-02-15T10:31:49Z

Fix for https://bugs.python.org/issue29553

berkerpeksag

I just did a quick review and the PR looks good in general, thank you. We also need an entry in Misc/NEWS (should be in "Library" section)

berkerpeksag · 2017-02-19T14:14:41Z

Lib/test/test_argparse.py

@@ -2725,6 +2725,35 @@ def get_parser(self, required):
          -c          c help
        '''

+class TestMutuallyExclusiveNested(TestCase):
+    def test_format_usage(self):
+        parser = ErrorRaisingArgumentParser(prog='PROG')


Is there a reason you can't use the existing test infrastructure? I think it's possible to convert these tests to follow the style of TestMutuallyExclusiveOptionalAndPositional: https://github.com/python/cpython/blob/82e38bd80113ecfc7aff2fb3edaf2802fe21c1fb/Lib/test/test_argparse.py#L2560

We can define a get_parser() method and use usage_when_required and usage_when_not_required to check output of parser.format_help().

…groups

andrewnester · 2017-02-19T17:29:30Z

@berkerpeksag thanks! just updated my PR.

Fix the first of several leaks. This one affects generator objects, which get finalised without being exhausted. https://bitbucket.org/stackless-dev/stackless/issues/117 (grafted from 7e86b49712ae5228edcdd822cb4b7e633d7c4363)

…heduling.c to stacklesseval.c This change makes a few functions "static". This improves the readability of the code. (grafted from b04162d33bed4125633dbaca6c2f9a8ec13edb4f)

… in slp_eval_frame_*() This change simplifies the code, that prevents the link optimiser to optimise away the identical functions slp_eval_frame_*(). The new code is simpler, faster and makes the overall reference counting less hard to understand. (grafted from 72d9447daf24f9441289784714c307f4e1d5e79f)

Fix two reference leaks in the C-implementation of stackless.threads. https://bitbucket.org/stackless-dev/stackless/issues/117 (grafted from 0ed22581e9fc255195d9116446ab9b20bcf99ac8)

Fix two reference leaks in the C-implementation of tasklet.__setstate__(). This fix depends on the previous commit. Without the new frame reference counting logic, it could lead to a negative reference count. Probably issue python#117 is now completely fixed. https://bitbucket.org/stackless-dev/stackless/issues/117 (grafted from a89093b495d7d9a7c2420001f674077fb6c586d1)

…h C-Python Exception handling now follows suit the code of sys.exc_clear() and ceval.c set_exc_info(). This change helps to rule out reference leaks caused by inappropriate handling of traceback objects. https://bitbucket.org/stackless-dev/stackless/issues/117 (grafted from 36fc9e84a48999378a73173c179ba6beeabcf821)

…n code This feature makes it possible to write tests for leaks caused by the watchdog list. The feature is intentionally undocumented, because it depends on implementation details. https://bitbucket.org/stackless-dev/stackless/issues/117 (grafted from 926f8eb7666730436799f19923852a7d16ae83ed)

This commit adds tests to detect resources leaks and changes of global state. Additionally it adds utility functions for debugging and tests, which inevitably leak references. - StacklessTestCase now tests for watchdog list leaks. The setUp() and tearDown() method now assert that the watchdog list of all threads is empty. Fortunately, this new test didn't reveal unknown problems. - StacklessTestCase tearDown now kills blocked tasklets with C-state. Such tasklets may be kept alive by a reference to a transient bound-method object, which referenced by a C-function. - StacklessTestCase tearDown now checks that the switch-trap level is 0 and resets the level, if it was different. - StacklessTestCase now checks that no error-handler is registered at the end of a test and eventually removes the error handler. - Add a decorator for tests, which leak references. A test case, which creates a C-stack without a thread, inevitably leak all references hold by local C-variables in this stack slice. The decorator skips decorated test-cases during "huntrleaks"-runs (option "-R:"). Debugging additions: - StacklessTestCase got two (experimental) methods to trace tasklet switching. https://bitbucket.org/stackless-dev/stackless/issues/117 (grafted from b2fc5542b34542abb275f8d1bc33691b0113bcaf)

- channelobject.c: Fix two reference leaks in the C-implementations of channel.send_throw() and channel.send_exception(). - stacklessmodule.c: Fix a reference leak in PyStackless_CallErrorHandler(), if Stackless runs a user defined error-handler. - ceval.c: Fix a reference leak in PyEval_EvalFrameEx_slp(), if a profile or trace function fails. - prickelpit.c and test_pickle.py: Fix reference leaks, if stackless._wrap.frame.__setstate__() fails, due to an invalid state. Add a test case. https://bitbucket.org/stackless-dev/stackless/issues/117 (grafted from f5d4ba8df893949daa6938b7161786783fb0c149)

This commit fixes problems in the Stackless test suite at Python level. It does not fix failures caused by reference leaks. - Fix failures, which occurred during a second or further run of the test. - Mark test-cases, which inevitably leak references. These tests leave a C-stack without thread. No chance to clean the references. https://bitbucket.org/stackless-dev/stackless/issues/117 (grafted from 7ae818842aa4783eb33be6a6085535ba18db97bc)

Stackless used to leak references to frames / C-frames, if a tasklet didn't run to its end, or various other conditions. This part of the fix changes the Stackless reference counting for frames to follow the general rules for Python objects. The concept of an "execute reference" no longer exists. Frames no longer eat their reference. See Stackless/core/stackless_impl.h for a detailed explanation. This patch adds a special frame reference counting debug mode, which can be enabled in stackless_tstate.h. https://bitbucket.org/stackless-dev/stackless/issues/117 (grafted from 9e9a2cea45059e87d025a1867beb8b0e3369262d)

brettcannon · 2018-02-21T01:53:27Z

To try and help move older pull requests forward, we are going through and backfilling 'awaiting' labels on pull requests that are lacking the label. Based on the current reviews, the best we can tell in an automated fashion is that a core developer requested changes to be made to this pull request.

If/when the requested changes have been made, please leave a comment that says, I have made the requested changes; please review again. That will trigger a bot to flag this pull request as ready for a follow-up review.

…ute() I missed the C-fame case, when I changed the frame-function ref counting in Stackless issue python#117.

flavianh · 2019-07-27T09:43:20Z

Recreated at #14976

aeros · 2019-08-22T22:02:27Z

Since this PR has not received a response from the author since the awaiting changes label was added on Feb 20, 2018 and was recreated at #14976, I'm closing it.

the-knights-who-say-ni added the CLA signed label Feb 15, 2017

andrewnester mentioned this pull request Feb 15, 2017

Alternarive for bpo-29553 - Fixed ArgumentParses format_usage for mutually exclusive groups #120

Closed

berkerpeksag requested changes Feb 19, 2017

View reviewed changes

berkerpeksag changed the title ~~bpo-29553 - Fixed ArgumentParses format_usage for mutually exclusive groups~~ bpo-29553: Fixed ArgumentParses format_usage for mutually exclusive groups Feb 19, 2017

andrewnester added 3 commits February 19, 2017 20:21

bpo-29553 - Fixed ArgumentParses format_usage for mutually exclusive …

d01e2ee

…groups

Updated test for ArgumentParser

12677f8

Updated MISC/NEWS

882091b

akruis pushed a commit to akruis/cpython that referenced this pull request Sep 9, 2017

merge 3.3-slp (Stackless python#117)

28e4aa6

akruis pushed a commit to akruis/cpython that referenced this pull request Sep 9, 2017

merge 3.4-slp (Stackless python#117)

f050cf2

akruis pushed a commit to akruis/cpython that referenced this pull request Sep 9, 2017

merge 3.3-slp (Stackless python#117, code cleanup)

efbee92

akruis pushed a commit to akruis/cpython that referenced this pull request Sep 9, 2017

merge 3.4-slp (Stackless python#117, code cleanup)

32d50a2

akruis pushed a commit to akruis/cpython that referenced this pull request Sep 9, 2017

merge 3.3-slp (Stackless python#117, ceval.c cleanup)

33080ce

akruis pushed a commit to akruis/cpython that referenced this pull request Sep 9, 2017

merge 3.4-slp (Stackless python#117, ceval.c cleanup)

462f201

akruis pushed a commit to akruis/cpython that referenced this pull request Sep 9, 2017

merge 3.3-slp (Stackless python#117, exception handling)

230c713

akruis pushed a commit to akruis/cpython that referenced this pull request Sep 9, 2017

merge 3.4-slp (Stackless python#117, exception handling)

231c0e2

akruis pushed a commit to akruis/cpython that referenced this pull request Sep 9, 2017

merge 3.3-slp (Stackless python#117, stackless.threads)

bf7284a

akruis pushed a commit to akruis/cpython that referenced this pull request Sep 9, 2017

merge 3.4-slp (Stackless python#117, stackless.threads)

344e682

akruis pushed a commit to akruis/cpython that referenced this pull request Sep 9, 2017

merge 3.3-slp (Stackless python#117, st.watchdogs)

efa2504

akruis pushed a commit to akruis/cpython that referenced this pull request Sep 9, 2017

merge 3.4-slp (Stackless python#117, st.watchdogs)

e13d0e6

akruis pushed a commit to akruis/cpython that referenced this pull request Sep 9, 2017

merge 3.3-slp (Stackless python#117, StacklessTestCase)

e0f01d1

akruis pushed a commit to akruis/cpython that referenced this pull request Sep 9, 2017

merge 3.4-slp (Stackless python#117, StacklessTestCase)

298c15f

akruis pushed a commit to akruis/cpython that referenced this pull request Sep 9, 2017

merge 3.3-slp (Stackless python#117, fix test cases)

dc3cfaf

akruis pushed a commit to akruis/cpython that referenced this pull request Sep 9, 2017

merge 3.4-slp (Stackless python#117, fix test cases)

922a6f0

akruis pushed a commit to akruis/cpython that referenced this pull request Sep 9, 2017

merge 3.3-slp (Stackless python#117, fix various reference leaks)

cdf9d54

akruis pushed a commit to akruis/cpython that referenced this pull request Sep 9, 2017

merge 3.4-slp (Stackless python#117, fix various reference leaks)

a3d95de

akruis pushed a commit to akruis/cpython that referenced this pull request Sep 9, 2017

merge 3.3-slp (Stackless python#117, fix frame reference leaks)

405a9cd

akruis pushed a commit to akruis/cpython that referenced this pull request Sep 9, 2017

merge 3.4-slp (Stackless python#117, fix frame reference leaks)

3272cdf

akruis pushed a commit to akruis/cpython that referenced this pull request Sep 9, 2017

merge 3.3-slp (Stackless python#117, tasklet.__setstate__())

da776ec

akruis pushed a commit to akruis/cpython that referenced this pull request Sep 9, 2017

merge 3.4-slp (Stackless python#117, tasklet.__setstate__())

fb4997d

Mariatta added needs rebase and removed needs rebase labels Oct 9, 2017

brettcannon added the awaiting changes label Feb 21, 2018

akruis pushed a commit to akruis/cpython that referenced this pull request Nov 1, 2018

Stackless issue python#177: Fix prickelpit.c function slp_cannot_exec…

5a574b8

…ute() I missed the C-fame case, when I changed the frame-function ref counting in Stackless issue python#117.

flavianh mentioned this pull request Jul 27, 2019

bpo-29553: Fixed ArgumentParses format_usage for mutually exclusive groups #14976

Merged

aeros closed this Aug 22, 2019

aeros mentioned this pull request Aug 23, 2019

Write guidelines about closing PR/issue by triagers python/devguide#527

Closed

jaraco pushed a commit that referenced this pull request Dec 2, 2022

Update celery from 4.2.0 to 4.2.1 (#117)

1a36e90

gvanrossum mentioned this pull request Aug 22, 2023

heap-use-after-free in _PyFunction_LookupByVersion #108253

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bpo-29553: Fixed ArgumentParses format_usage for mutually exclusive groups #117

bpo-29553: Fixed ArgumentParses format_usage for mutually exclusive groups #117

andrewnester commented Feb 15, 2017

berkerpeksag left a comment

berkerpeksag Feb 19, 2017

andrewnester commented Feb 19, 2017

brettcannon commented Feb 21, 2018

flavianh commented Jul 27, 2019

aeros commented Aug 22, 2019 •

edited

Loading

bpo-29553: Fixed ArgumentParses format_usage for mutually exclusive groups #117

bpo-29553: Fixed ArgumentParses format_usage for mutually exclusive groups #117

Conversation

andrewnester commented Feb 15, 2017

berkerpeksag left a comment

Choose a reason for hiding this comment

berkerpeksag Feb 19, 2017

Choose a reason for hiding this comment

andrewnester commented Feb 19, 2017

brettcannon commented Feb 21, 2018

flavianh commented Jul 27, 2019

aeros commented Aug 22, 2019 • edited Loading

aeros commented Aug 22, 2019 •

edited

Loading