Alternarive for bpo-29553 - Fixed ArgumentParses format_usage for mutually exclusive groups #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewnester
changed the title
berkerpeksag
requested changes
Feb 19, 2017
|
@berkerpeksag thanks! just updated my PR. |
zhangyangyu
reviewed
Feb 22, 2017
Misc/NEWS
Outdated
| @@ -251,6 +251,7 @@ Library | |||
|
|
|||
| - bpo-29576: Improve some deprecations in importlib. Some deprecated methods | |||
| now emit DeprecationWarnings and have better descriptive messages. | |||
There was a problem hiding this comment.
We need an empty line here.
There was a problem hiding this comment.
@zhangyangyu updated, sorry! thanks!
akruis
pushed a commit
to akruis/cpython
that referenced
this pull request
Sep 9, 2017
akruis
pushed a commit
to akruis/cpython
that referenced
this pull request
Sep 9, 2017
Stackless now correctly grabs and releases the head_mutex, if it iterates over the linked list of Py_ThreadState structures. https://bitbucket.org/stackless-dev/stackless/issues/120 (grafted from 1fb75d58a98083b2547746adb21fa238bbf8135a)
akruis
pushed a commit
to akruis/cpython
that referenced
this pull request
Sep 9, 2017
akruis
pushed a commit
to akruis/cpython
that referenced
this pull request
Sep 9, 2017
This commit fixes a regression introduced by commit fc13eecdd0ad. When I grafted the patch for this issue from branch 2.7-slp (1fb75d58a), I forgot to remove a 2.7-slp only part of the code. In effect, this change reapplies commit b8a8122bbb91. https://bitbucket.org/stackless-dev/stackless/issues/120
akruis
pushed a commit
to akruis/cpython
that referenced
this pull request
Sep 9, 2017
akruis
pushed a commit
to akruis/cpython
that referenced
this pull request
Sep 9, 2017
|
To try and help move older pull requests forward, we are going through and backfilling 'awaiting' labels on pull requests that are lacking the label. Based on the current reviews, the best we can tell in an automated fashion is that a core developer requested changes to be made to this pull request. If/when the requested changes have been made, please leave a comment that says, |
|
Superseded by PR #14976. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for https://bugs.python.org/issue29553
Alternative to #117
This alternative advised by Christoph Stahl and Brian Curtin