You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR:
1 Breaks CALL_ALLOC_AND_ENTER_INIT into micro-ops, so that it can be included in tier 2 traces
2 Relaxes the requirement exact arguments, so that more calls to Python classes are inlined.
3 Passes the previous frame to the various PyInterpreterFrame creation functions.
(3) above seems more logical than setting the previous field separately, and is necessary to break up CALL_ALLOC_AND_ENTER_INIT as it pushes two frames.
markshannon
changed the title
Make CALL_ALLOC_AND_ENTER_INIT suitable for tier 2.
GH-118093: Make CALL_ALLOC_AND_ENTER_INIT suitable for tier 2.
Aug 19, 2024
Summary of the results of the build (if available):
==
Click to see traceback logs
Traceback (most recent call last):
File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z.refleak/build/Lib/test/test_socket.py", line 6861, in test_addresswith socket.create_server(("::1", port),
~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^
family=socket.AF_INET6) as sock:
^^^^^^^^^^^^^^^^^^^^^^^
File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z.refleak/build/Lib/socket.py", line 947, in create_serverraise error(err.errno, msg) fromNoneOSError: [Errno 98] Address already in use (while attempting to bind on address ('::1', 54943))
Summary of the results of the build (if available):
==
Click to see traceback logs
Traceback (most recent call last):
File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-x86_64.refleak/build/Lib/test/test_glob.py", line 543, in test_selflinkself.assertIn(path, results)
~~~~~~~~~~~~~^^^^^^^^^^^^^^^
AssertionError: 'dir/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/file' not found in {'dir/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/file', 'dir/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/file', 'dir/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/file', 'dir/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/file', 'dir/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/link/file'}
pythonGH-123140)
* Convert CALL_ALLOC_AND_ENTER_INIT to micro-ops such that tier 2 supports it
* Allow inexact arguments for CALL_ALLOC_AND_ENTER_INIT.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
1 Breaks
CALL_ALLOC_AND_ENTER_INIT
into micro-ops, so that it can be included in tier 2 traces2 Relaxes the requirement exact arguments, so that more calls to Python classes are inlined.
3 Passes the
previous
frame to the variousPyInterpreterFrame
creation functions.(3) above seems more logical than setting the
previous
field separately, and is necessary to break upCALL_ALLOC_AND_ENTER_INIT
as it pushes two frames.