Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.13] gh-122712: Guard against __code__ reassignment in CALL_ALLOC_AND_ENTER_INIT (GH-122713) #123184

Merged
merged 2 commits into from
Aug 21, 2024

Conversation

mpage
Copy link
Contributor

@mpage mpage commented Aug 20, 2024

Verify the necessary properties of the function's code object in CALL_ALLOC_AND_ENTER_INIT to guard against someone reassigning code.

@mpage mpage requested a review from brandtbucher August 20, 2024 20:30
@mpage mpage changed the title gh-122712: Guard against __code__ reassignment in CALL_ALLOC_AND_ENTER_INIT gh-122712: Guard against __code__ reassignment in CALL_ALLOC_AND_ENTER_INIT (GH-122713) Aug 20, 2024
@mpage mpage changed the title gh-122712: Guard against __code__ reassignment in CALL_ALLOC_AND_ENTER_INIT (GH-122713) [3.13] gh-122712: Guard against __code__ reassignment in CALL_ALLOC_AND_ENTER_INIT (GH-122713) Aug 20, 2024
@mpage
Copy link
Contributor Author

mpage commented Aug 20, 2024

JIT failures look like qemu issues and are unrelated to this diff:

ERROR:../../plugins/core.c:221:qemu_plugin_vcpu_init_hook: assertion failed: (success)
Bail out! ERROR:../../plugins/core.c:221:qemu_plugin_vcpu_init_hook: assertion failed: (success)
aarch64-binfmt-P: ./include/qemu/rcu.h:101: rcu_read_unlock: Assertion `p_rcu_reader->depth != 0' failed.

@mpage mpage marked this pull request as ready for review August 20, 2024 22:12
@mpage mpage requested a review from markshannon as a code owner August 20, 2024 22:12
@mpage
Copy link
Contributor Author

mpage commented Aug 20, 2024

@brandtbucher @markshannon - This is a backport of gh-122713 for 3.13. Happy to continue with this or let you take care of backporting gh-123140 to 3.13.

@markshannon markshannon merged commit 50a595b into python:3.13 Aug 21, 2024
56 of 58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants