-
-
Notifications
You must be signed in to change notification settings - Fork 30.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[backport to 2.7] bpo-29529: Add .travis.yml to 2.7 branch #27
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will need some updates to handle 2.7.
.travis.yml
Outdated
include: | ||
- os: linux | ||
language: python | ||
python: 3.5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/3.5/2.7/
.travis.yml
Outdated
- TESTING=docs | ||
before_script: | ||
- cd Doc | ||
- make venv PYTHON=python3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since there is no make venv
on 2.7, just do pip install -U Sphinx
(or add a 'venv' target, but that's a bit weird since there is no 'venv' module in 2.7).
.travis.yml
Outdated
- cd Doc | ||
- make venv PYTHON=python3 | ||
script: | ||
- make html SPHINXBUILD="./venv/bin/python3 -m sphinx" SPHINXOPTS="-q" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Along with the make venv
change, remove SPHINXBUILD
here.
.travis.yml
Outdated
- ./configure | ||
- make -s -j4 | ||
# Need a venv that can parse covered code. | ||
- ./python -m venv venv |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This won't fly with 2.7, but I'm not sure what we can do instead to fix it. On the other hand, do we care as much about coverage on 2.7?
GH-74 has some proposed changes to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the requested changes have now been made
There are a couple of other changes to be backported, but the changes I requested have been made. |
Leave a comment when status checks for the backport PR are done. Only leave the comment on backports made by @miss-islington. Mention the original PR author and the core dev who merged the original PR. Closes python/miss-islington#26
* Add a missing dependency for Python 3.4 * Fix coverage for Python 3.4
27: Clean up tests for -3 run r=ltratt a=nanjekyejoannah Test clean up before fix to `ceval`. Co-authored-by: Joannah Nanjekye <[email protected]>
* Fix: Buggy pointer magic in copying type context Added better debugging for type context * Refactor: Rename vars
No description provided.