Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notify when backport PRs failed #26

Closed
Mariatta opened this issue Sep 13, 2017 · 4 comments
Closed

Notify when backport PRs failed #26

Mariatta opened this issue Sep 13, 2017 · 4 comments

Comments

@Mariatta
Copy link
Member

In python/cpython#3548, the pr backports cleanly without conflict, but the test suite failed.

Some ideas of what @miss-islington can do:

  • notify the original PR author, or the core dev merging the PR, that the backport failed (leave a comment)
  • automatically close the backport PR? because it now requires manual backport. A core dev can close it too.
  • re-add the needs backport to [X.Y] label to the original PR
@Mariatta
Copy link
Member Author

Can't re-add the label since it'll trigger another auto-backport .. 🤔

@terryjreedy
Copy link
Member

If the PR merges back cleanly, leave it alone. Miss Islington has done here job. Let the author and core dev decided whether to close and start over with git cherry-pick or to pull the backport patches. (I assume that Miss Islington allows edits.) The latter should usually be easier.

I would like to always get an email when Travis and Appveyor finish a backport test, so there is no or less need to keep checking in the browser.

@Mariatta
Copy link
Member Author

I would like to always get an email when Travis and Appveyor finish a backport test, so there is no or less need to keep checking in the browser.

Sounds good. I can make Miss Islington leave a comment once the status checks are done, and she can mention the PR author and the core dev who merged the PR.
During the sprint some core devs also wanted to have this notification for regular PRs too.

@Mariatta
Copy link
Member Author

python/cpython#3618 (comment) is an example where @miss-islington leaves a comment when all status checks are done.

Mariatta added a commit that referenced this issue Sep 16, 2017
Leave a comment when status checks for the backport PR are done.
Only leave the comment on backports made by @miss-islington.
Mention the original PR author and the core dev who merged the original PR.
Closes #26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants