-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notify when backport PRs failed #26
Comments
Can't re-add the label since it'll trigger another auto-backport .. 🤔 |
If the PR merges back cleanly, leave it alone. Miss Islington has done here job. Let the author and core dev decided whether to close and start over with git cherry-pick or to pull the backport patches. (I assume that Miss Islington allows edits.) The latter should usually be easier. I would like to always get an email when Travis and Appveyor finish a backport test, so there is no or less need to keep checking in the browser. |
Sounds good. I can make Miss Islington leave a comment once the status checks are done, and she can mention the PR author and the core dev who merged the PR. |
python/cpython#3618 (comment) is an example where @miss-islington leaves a comment when all status checks are done. |
Leave a comment when status checks for the backport PR are done. Only leave the comment on backports made by @miss-islington. Mention the original PR author and the core dev who merged the original PR. Closes #26
In python/cpython#3548, the pr backports cleanly without conflict, but the test suite failed.
Some ideas of what @miss-islington can do:
The text was updated successfully, but these errors were encountered: