Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only mention author on backport PRs in case of errors #272

Closed
blueyed opened this issue Sep 12, 2019 · 1 comment · Fixed by #481
Closed

Only mention author on backport PRs in case of errors #272

blueyed opened this issue Sep 12, 2019 · 1 comment · Fixed by #481

Comments

@blueyed
Copy link

blueyed commented Sep 12, 2019

Initially done via #27 for #26.

#26 was asking for this to be done in case of errors, but it gets done always.

This caused like 4+ notifications due to a PR being backported to 3.7 and 3.8.

Ref: python/cpython#16066 (comment)

@blueyed
Copy link
Author

blueyed commented Sep 12, 2019

Apart from that it happened again for unknown reasons on python/cpython#16066 (comment)?

maxking added a commit to maxking/miss-islington that referenced this issue Sep 20, 2019
"@" usually doesn't give any information about what exactly the handle means
since we don't know it is a Github handle from the commit message.

Changing the pattern to be `GH:` similar to what we do for Pull Requests
with (GH-).

Fixes python#272
maxking added a commit to maxking/miss-islington that referenced this issue Sep 20, 2019
"@" usually doesn't give any information about what exactly the handle means
since we don't know it is a Github handle from the commit message.

Changing the pattern to be `GH:` similar to what we do for Pull Requests
with (GH-).

Fixes python#272
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant