Dismissed review not respected #62
Assignees
Labels
Comments
Mariatta
added a commit
that referenced
this issue
Jun 29, 2018
Change the behavior for when deciding when miss-islington should merge the PR. Previously it checks if the PR has one core dev who approved the PR. But that is unreliable because the review may be dismissed later, or another core dev might decide not to backport the PR anymore. The "awaiting merge" label is a better indicator that the PR is ready for merge. Adjust tests. Fixes #62
Mariatta
added a commit
that referenced
this issue
Jun 29, 2018
Change the behavior for when deciding when miss-islington should merge the PR. Previously it checks if the PR has one core dev who approved the PR. But that is unreliable because the review may be dismissed later, or another core dev might decide not to backport the PR anymore. The "awaiting merge" label is a better indicator that the PR is ready for merge. Adjust tests. Fixes #62
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In python/cpython#5746, two core devs approved the PR initially, but later both reviews were dismissed.
miss-islington still went ahead and merged the PR.
The PR shouldn't have been merged in this case.
The text was updated successfully, but these errors were encountered: