Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't merge PR unless it has "awaiting merge" label #112

Merged
merged 6 commits into from
Jun 29, 2018
Merged

Conversation

Mariatta
Copy link
Member

Change the behavior for when deciding when miss-islington
should merge the PR.

Previously it checks if the PR has one core dev who approved the PR.
But that is unreliable because the review may be dismissed later,
or another core dev might decide not to backport the PR anymore.

The "awaiting merge" label is a better indicator that the PR
is ready for merge.

Adjust tests.

Fixes #62

Change the behavior for when deciding when miss-islington
should merge the PR.

Previously it checks if the PR has one core dev who approved the PR.
But that is unreliable because the review may be dismissed later,
or another core dev might decide not to backport the PR anymore.

The "awaiting merge" label is a better indicator that the PR
is ready for merge.

Adjust tests.

Fixes #62
@codecov
Copy link

codecov bot commented Jun 29, 2018

Codecov Report

Merging #112 into master will increase coverage by 1.11%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #112      +/-   ##
==========================================
+ Coverage    91.1%   92.22%   +1.11%     
==========================================
  Files           9        9              
  Lines         551      566      +15     
  Branches       40       40              
==========================================
+ Hits          502      522      +20     
+ Misses         49       44       -5
Impacted Files Coverage Δ
tests/test_delete_branch.py 100% <ø> (+4.44%) ⬆️
miss_islington/status_change.py 100% <100%> (ø) ⬆️
tests/test_util.py 100% <100%> (+4.22%) ⬆️
miss_islington/util.py 75% <100%> (+2.11%) ⬆️
tests/test_status_change.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 863dde5...7cdc302. Read the comment docs.

@Mariatta Mariatta added the black out Apply to PR. It will run "black" label Jun 29, 2018
@miss-islington
Copy link
Collaborator

🐍🌚🤖 @Mariatta, I've formatted these files using black:

  • miss_islington/status_change.py
  • miss_islington/util.py
  • tests/test_status_change.py
  • tests/test_util.py
    (I'm a bot 🤖)

@miss-islington miss-islington removed the black out Apply to PR. It will run "black" label Jun 29, 2018
@Mariatta Mariatta merged commit 8fe9d1f into master Jun 29, 2018
@Mariatta Mariatta deleted the issue-62 branch June 29, 2018 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants