Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix LSP violations in test files #18362

Merged
merged 1 commit into from
Dec 29, 2024
Merged

Fix LSP violations in test files #18362

merged 1 commit into from
Dec 29, 2024

Conversation

cdce8p
Copy link
Collaborator

@cdce8p cdce8p commented Dec 29, 2024

Extracted from #18356

cdce8p
cdce8p commented Dec 29, 2024
View reviewed changes
mypy/test/testpep561.py
Comment on lines -26 to +27
def run_case(self, test_case: DataDrivenTestCase) -> None:
test_pep561(test_case)
def run_case(self, testcase: DataDrivenTestCase) -> None:
test_pep561(testcase)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#18356 changed the superclass implementation instead. However as this is the only violation, I'm not sure that's necessary here.

mypy/mypy/test/data.py

Lines 818 to 820 in d79d89e

@abstractmethod
def run_case(self, testcase: DataDrivenTestCase) -> None:
raise NotImplementedError

@cdce8p cdce8p requested a review from hauntsaninja December 29, 2024 20:35
@cdce8p cdce8p mentioned this pull request Dec 29, 2024
Closed
@hauntsaninja hauntsaninja merged commit 3433a0e into python:master Dec 29, 2024
12 checks passed
@cdce8p cdce8p deleted the fix-subtypes-tests branch December 29, 2024 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hauntsaninja hauntsaninja hauntsaninja approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cdce8p @hauntsaninja