Ensure LSP compatibility on arg names in mypy #18356
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pairs well with python#18355
hauntsaninja
changed the title
for more information, see https://pre-commit.ci
This was referenced Dec 29, 2024
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
cdce8p
reviewed
Dec 29, 2024
| if info is None: | ||
| if info is None or any(has_placeholder(tv) for tv in tvar_defs): |
There was a problem hiding this comment.
This looks like the change from #18351
This was referenced Dec 29, 2024
hauntsaninja
pushed a commit
that referenced
this pull request
Dec 29, 2024
Extracted from #18356. Make `visit_*` method arguments positional only to ensure better LSP compatibility. Also update some visitors which don't have violations yet but are base classes for other ones, like `TypeTranslator` and `TypeQuery`.
hauntsaninja
added a commit
that referenced
this pull request
Dec 30, 2024
Got lost when #18356 was broken up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pairs well with #18355