-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More LSP compatibility on arg names #18363
Conversation
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer positional-only arguments here, since this is part of mypy's plugin API. This way plugin authors get errors upfront, instead of perhaps later when running their plugin against an older version of mypy.
Makes sense. The methods marked with pos-only are unlikely to be called with keyword args anyway. Would you mind updating the argument names in the implementation, so that these are at least consistent (i.e. the ones I liked to above)? |
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @hauntsaninja 👍🏻
Last thing, could you also update the comment on the API changes issue? I don't have the permission to do that, unfortunately. #6617 (comment)
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
Got lost when #18356 was broken up