Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 1: Relax CODEOWNERS rule to allow PEP editors to "own" PEPs #2252

Merged
merged 7 commits into from
Jan 20, 2022

Conversation

AA-Turner
Copy link
Member

@CAM-Gerlach
Copy link
Member

Yeah, it certainly seems like a simple oversight to me; PEP 1 may not have envisioned PEP editors who weren't core developers, like you, me and @JelleZijlstra are today. This affects you too on PEP 676, and @JelleZijlstra is already listed as CODEOWNER on PEP 673 and PEP 675, so it seems worth clarifying (even if, I think, we all understand the intent of it).

@CAM-Gerlach CAM-Gerlach requested a review from a team January 20, 2022 05:02
@AA-Turner
Copy link
Member Author

Build failed due to reST typo, now fixed.

Copy link
Member

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#2112 is where we generally approved PEP editors as sponsors. This is consistent with that change.

Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small textual suggestions; otherwise ✔️ from me

pep-0001.txt Outdated Show resolved Hide resolved
pep-0001.txt Outdated Show resolved Hide resolved
pep-0001.txt Outdated Show resolved Hide resolved
@AA-Turner AA-Turner changed the title Relax CODEOWNERS rule to allow PEP editors to "own" PEPs PEP 1: Relax CODEOWNERS rule to allow PEP editors to "own" PEPs Jan 20, 2022
@AA-Turner
Copy link
Member Author

AA-Turner commented Jan 20, 2022

We've three PEP editors approving, I'll wait until tomorrow afternoon (~4pm UTC, 20/01) and merge if there's no negative comments

A

@Rosuav
Copy link
Contributor

Rosuav commented Jan 20, 2022

I wonder if the last sentence might be less awkward as "sponsor/co-author(s) are added"? The singular/plural discrepancy is hard to handle, but maybe combining them might feel better.

@CAM-Gerlach
Copy link
Member

Great suggestion @Rosuav ; this also bypasses the "and"/"or" issue I was haggling over

pep-0001.txt Outdated Show resolved Hide resolved
Co-authored-by: Chris Angelico <[email protected]>
@AA-Turner AA-Turner merged commit b16058c into python:main Jan 20, 2022
@AA-Turner
Copy link
Member Author

Thanks all for the reviews, merged
A

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants