-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PEP 1: Relax CODEOWNERS rule to allow PEP editors to "own" PEPs #2252
Conversation
Yeah, it certainly seems like a simple oversight to me; PEP 1 may not have envisioned PEP editors who weren't core developers, like you, me and @JelleZijlstra are today. This affects you too on PEP 676, and @JelleZijlstra is already listed as CODEOWNER on PEP 673 and PEP 675, so it seems worth clarifying (even if, I think, we all understand the intent of it). |
Build failed due to reST typo, now fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#2112 is where we generally approved PEP editors as sponsors. This is consistent with that change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two small textual suggestions; otherwise ✔️ from me
We've three PEP editors approving, I'll wait until tomorrow afternoon (~4pm UTC, 20/01) and merge if there's no negative comments A |
I wonder if the last sentence might be less awkward as "sponsor/co-author(s) are added"? The singular/plural discrepancy is hard to handle, but maybe combining them might feel better. |
Great suggestion @Rosuav ; this also bypasses the "and"/"or" issue I was haggling over |
Co-authored-by: Chris Angelico <[email protected]>
Thanks all for the reviews, merged |
xref #2228 (comment)
A