Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 1: Relax CODEOWNERS rule to allow PEP editors to "own" PEPs #2252

Merged
merged 7 commits into from
Jan 20, 2022
Merged

PEP 1: Relax CODEOWNERS rule to allow PEP editors to "own" PEPs #2252

Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
22b0731
Relax CODEOWNERS rule to allow PEP editors to "own" PEPs
AA-Turner Jan 20, 2022
fe48157
fix spacing
AA-Turner Jan 20, 2022
c04eab6
Standardise access wording
AA-Turner Jan 20, 2022
5fa4f99
Standardise access wording redux
AA-Turner Jan 20, 2022
50ba35e
Don't use such that twice
AA-Turner Jan 20, 2022
8e7bd51
Wording update
CAM-Gerlach Jan 20, 2022
d5c3645
Plural agreement
AA-Turner Jan 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions pep-0001.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,9 +188,9 @@ The standard PEP workflow is:
"Informational", or "Process" as appropriate, and for the "Status:"
field enter "Draft". For full details, see `PEP Header Preamble`_.

* Update `.github/CODEOWNERS` [7]_ such that any core developer co-author(s) or
sponsor are listed for your new file such that any future pull requests will
be assigned to them.
* Update `.github/CODEOWNERS` [7]_ such that any co-author(s) or sponsors
with the commit bit on the `PEP repository`_ are listed for your new file
such that any future pull requests will be assigned to them.
AA-Turner marked this conversation as resolved.
Show resolved Hide resolved

* Push this to your GitHub fork and submit a pull request.

Expand Down Expand Up @@ -696,7 +696,7 @@ For each new PEP that comes in an editor does the following:

* The file name extension is correct (i.e. ``.rst``).

* Make sure the appropriate core developer(s) is added to
* Make sure the appropriate sponsor or co-author(s) are added to
AA-Turner marked this conversation as resolved.
Show resolved Hide resolved
AA-Turner marked this conversation as resolved.
Show resolved Hide resolved
`.github/CODEOWNERS` [7]_.

* Skim the PEP for obvious defects in language (spelling, grammar,
Expand Down