Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created transition BackendTestUtils2 #3260

Closed
wants to merge 1 commit into from

Conversation

gcatron
Copy link
Contributor

@gcatron gcatron commented Jul 19, 2019

Summary:
Created transition BackendTestUtils2 which is a copy of BackendTestUtils that has been ported to EE2. This is an intermediate step so tests can be ported one at a time. Once all users of BackendTestUtils have been ported BackendTestUtils2 will replace BackendTestUtils. Also ported HyphenTest which uses the new BackendUtils2.

Documentation: NA

Work on #3239

Test Plan: ninja check, verify HyphenTest passes.

Copy link

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gcatron has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

…ils that has beeen ported to EE2. This is an intermediate step so tests can be ported one at a time. Once all users of BackendTestUtils have been ported BackendTestUtils2 will replace BackendTestUtils. Also ported HyphenTest which uses the new BackendUtils2.
@gcatron gcatron force-pushed the backend_test_utils_ee2 branch from b7eacc9 to 3e44014 Compare July 19, 2019 00:35
Copy link

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gcatron has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@jfix71
Copy link
Contributor

jfix71 commented Jul 19, 2019

@gcatron Ok I have a (hopefully not too annoying) request 😄. In theory this PR shouldn't be so hard to review because there probably aren't so many differences between BackendTestUtils2 and BackendTestUtils. But in practice because there's a single commit here with the new BackendTestUtils2 files and so it's hard to tell what's changed vs the original versions.

So, instead of directly copying + adding the new BackendTestUtils2 files, can you do something like:

git mv BackendTestUtils.cpp BackendTestUtils2.cpp
git commit BackendTestUtils.cpp -m "Just moved old version to new"
cp BackendTestUtils2.cpp BackendTestUtils.cpp
git add BackendTestUtils.cpp
git commit BackendTestUtils.cpp -m "Bring back the old version with the same name"
// Make changes to BackendTestUtils2.cpp
git commit BackendTestUtils2.cpp -m "New changes."

Then on GH it'd be possible to see the actual meaningful changes to BackendTestUtils2.cpp in the "New changes" commit.

I tried the above out myself on EE->EE3 and it's pretty easy and works great. See this branch and this commit. And it would make reviewing this PR and similar ones in the future much easier/more effective.

@gcatron
Copy link
Contributor Author

gcatron commented Jul 19, 2019

Closing this PR, #3263 was created for the same changes but a series of stacked commits to make review easier.

@gcatron gcatron closed this Jul 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants