Port ExecutionEngine to use runtime #3239
Comments
facebook-github-bot
pushed a commit
that referenced
this issue
Jul 18, 2019
…3240) Summary: This PR ports MLTest to the new EE2, it also adds two new helper methods to PlaceholderBindings which are used in the port. Documentation: UnitTest and EE docs will be revisited when closing out #3239. Work on #3239 Pull Request resolved: #3240 Test Plan: MLTest builds and runs with the new EE2 Differential Revision: D16352460 Pulled By: gcatron fbshipit-source-id: 1035a344f30110839b1d8e999c8ca7ef8e15579b
This was referenced Jul 19, 2019
facebook-github-bot
pushed a commit
that referenced
this issue
Jul 19, 2019
Summary: Created transition BackendTestUtils2 which is a copy of BackendTestUtils that has been ported to EE2. This is an intermediate step so tests can be ported one at a time. Once all users of BackendTestUtils have been ported BackendTestUtils2 will replace BackendTestUtils. Also ported HyphenTest which uses the new BackendUtils2. For ease of reviewing look at the last diff in the stack, it will show what actually changed in BackendTestUtils. Documentation: NA Work on #3239 Pull Request resolved: #3263 Test Plan: ninja check, verify HyphenTest passes. Differential Revision: D16374266 Pulled By: gcatron fbshipit-source-id: 84203a5357ea40f2b1a91c175a223c8a684a9671
This was referenced Jul 22, 2019
facebook-github-bot
pushed a commit
that referenced
this issue
Jul 23, 2019
Summary: This PR ports the RecommendationSystemTest to the new EE2. Additionally this adds a new feature to EE2, the ability to set the memory of the device. This allows programmatically setting the EE device memory to support graphs larger than the default. Documentation: NA Work on #3239 Pull Request resolved: #3276 Test Plan: verify everything builds, and RecomendationSystemTest runs and passes. Differential Revision: D16429379 Pulled By: gcatron fbshipit-source-id: bff806e69dc897a54f20575492881660299e6d42
This was referenced Jul 23, 2019
Closed
facebook-github-bot
pushed a commit
that referenced
this issue
Jul 24, 2019
Summary: The PR ports the PartitionerTest to the new EE2 Documentation: Progress on #3239 Pull Request resolved: #3282 Test Plan: verify everything builds and that PartitionerTest runs and passes. Differential Revision: D16460233 Pulled By: gcatron fbshipit-source-id: 42c581d5b81547c9898b8b15c0d1c0a6e9b3bfde
facebook-github-bot
pushed a commit
that referenced
this issue
Jul 24, 2019
Summary: This Ports IROptTest to BackendTestUtils2, it's essentially a no-op but this will help ensure a smoother transition. Documentation: Progress on #3239 Pull Request resolved: #3292 Test Plan: build, run and pass IROptTest Differential Revision: D16460828 Pulled By: gcatron fbshipit-source-id: 62714822466149b4b2ac0546678f624cea9553f8
Closed
facebook-github-bot
pushed a commit
that referenced
this issue
Jul 26, 2019
Summary: Ported TraceEventsTest to EE2 Documentation: Progress on #3239 Pull Request resolved: #3296 Test Plan: verify everything builds and TraceEventsTest runs and passes. Reviewed By: compnerd, rdzhabarov Differential Revision: D16472825 Pulled By: gcatron fbshipit-source-id: 197aa5ebf0d879e9505e559bb6c1accc7def1160
facebook-github-bot
pushed a commit
that referenced
this issue
Jul 28, 2019
Summary: Ported SparseLengthsSumTest to EE2 Documentation: Progress on #3239 Pull Request resolved: #3309 Test Plan: Verify everything builds, Verify SparseLengthsSumTest runs and passes. (I'm not sure this is actually tested in CI. Verified to run on my laptop.) Reviewed By: shajrawi, rdzhabarov Differential Revision: D16521082 Pulled By: gcatron fbshipit-source-id: de5a8c707321fe838ddd800ab9b686f6106c5cbf
This was referenced Aug 1, 2019
facebook-github-bot
pushed a commit
that referenced
this issue
Aug 2, 2019
Summary: This PR Ports HabanaBackendTest to EE2. Documentation: Progress on #3239 Pull Request resolved: #3364 Test Plan: Still in testing, on a machine with Habana hardware build and verify test runs and passes. Differential Revision: D16611388 Pulled By: gcatron fbshipit-source-id: f31038e21734571260e4cb74b9b0ef2d5663d0ff
facebook-github-bot
pushed a commit
that referenced
this issue
Aug 2, 2019
Summary: Ported resnet-verify to EE2 Documentation: Progress on #3239 Pull Request resolved: #3363 Test Plan: Verify everything builds, Run resnet-verify and ensure it completes successfully. I don't think this is run as part of CI. Tested locally on my machine. Differential Revision: D16610450 Pulled By: gcatron fbshipit-source-id: 264102d59de5f750a1277a1b81f0927fbf626a81
This was referenced Aug 2, 2019
facebook-github-bot
pushed a commit
that referenced
this issue
Aug 2, 2019
Summary: Ported resnet-runtime to EE2 Documentation: Progress on #3239 Pull Request resolved: #3370 Test Plan: verify builds, run resnet-runtime and sure it runs and images are categorized correctly. Differential Revision: D16624425 Pulled By: gcatron fbshipit-source-id: adae31dbc94d407e489790416c1dcd61445743cd
facebook-github-bot
pushed a commit
that referenced
this issue
Aug 2, 2019
Summary: Ported TracingCompare to EE2 Documentation: Progress on #3239 Pull Request resolved: #3371 Test Plan: verify everything builds, run tracing-compare and note that the same 726 events are dumped. Differential Revision: D16626212 Pulled By: gcatron fbshipit-source-id: a88c4fc98b7711a6a10c192f0707749f913f5955
facebook-github-bot
pushed a commit
that referenced
this issue
Aug 3, 2019
Closed
facebook-github-bot
pushed a commit
that referenced
this issue
Aug 5, 2019
Summary: Ported loader to EE2, also ported ImageClassifier, TextTranslator, and ModelRunner Documentation: Progress on #3239 Pull Request resolved: #3377 Test Plan: verify everything builds and ImageClassifier, TextTranslator, and ModelRunner run correctly. Differential Revision: D16650941 Pulled By: gcatron fbshipit-source-id: ff18674980874c6c431414ae1ba7006c83280785
Closed
facebook-github-bot
pushed a commit
that referenced
this issue
Aug 6, 2019
Summary: This PR replaces the old EE with the new EE2, this removes the old EE and BackendTestUtils and renames EE2 and BackendTestUtils2 to take their place. This PR also updates all instance of EE2 and BackendTestUtils2 Documentation: Coming soon.. There will be a follow up PR to update docs and close the port. Progress on #3239 Pull Request resolved: #3388 Test Plan: Verify everything builds, and unit tests pass. NFC just mechanical. Reviewed By: bertmaher Differential Revision: D16671350 Pulled By: gcatron fbshipit-source-id: ff4f1ee0c9a6bb87764ad12cbb4414832a4f04d9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Port the ExecutionEngine to the new runtime interface through HostManager and update all Tests that use the EE.
The plan of action:
Port all tests and uses of EE and BackendTestUtils to EE2 BackendUtils2. Once all files have been migrated remove original ExecutionEngine and BackendTestUtils and rename ExecutionEngine2 to ExecutionEngine and BackendTestUtils2 to BackendTestUtils.
For several tests the port will be a no-op but moving it will make it easier to ensure nothing is missed.
The text was updated successfully, but these errors were encountered: