Ported SparseLengthsSumTest to EE2 #3309
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcatron
force-pushed
the
sparse_lengths_sum_test_ee2
branch
from
c71857e to
a7b4462
Compare
There was a problem hiding this comment.
@gcatron has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
gcatron
force-pushed
the
sparse_lengths_sum_test_ee2
branch
from
a7b4462 to
00661d6
Compare
There was a problem hiding this comment.
@gcatron has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
gcatron
force-pushed
the
sparse_lengths_sum_test_ee2
branch
from
00661d6 to
7632207
Compare
There was a problem hiding this comment.
@gcatron has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
rdzhabarov
reviewed
Jul 27, 2019
| class SparseLengthsSum : public BackendTest {}; | ||
| class SparseLengthsSum : public BackendTest { | ||
| public: | ||
| ~SparseLengthsSum() override{}; |
There was a problem hiding this comment.
dtor in the base class needs to be virtual.
rdzhabarov
approved these changes
Jul 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:Ported SparseLengthsSumTest to EE2
Documentation:
Progress on #3239
Test Plan: Verify everything builds, Verify SparseLengthsSumTest runs and passes. (I'm not sure this is actually tested in CI. Verified to run on my laptop.)