First proposal for the MixedMapper and MixedOp #1188
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
7 tasks
|
Update on the status of this PR.
|
* Formatting error message An space was missing here as well. * Space missing Another space missing.
Welcome to Algorithmiq!
After reviewing the members of the `qiskit-nature` Github organization team, the only member without explicit other permissions in this repo was @stefan-woerner. Based on an offline discussion he agreed that his ownership and permissions are no longer required which is why I am removing him from this file. Subsequently, I will also remove the `qiskit-nature` team from the repository settings since we can rather add individual members in the future (rather than first adding everyone to the qiskit-community Github organization and subsequently a single team; since we will have less overlapping members across multiple repositories).
In order to deploy the documentation to the public URL, a Github action needs to be triggered manually. In order to avoid anyone being able to do this, the script which is being run asserts the username of the `github.actor` to be in a hard-coded list of authorized users. This commit updates this list in accordance with the recent CODEOWNER changes. I believe, that there must be a better way to handle/restrict access to who can trigger this action, but for the time being I will simply do this quick fix.
* fix pylint errors due to version update * fix copyright years * Update qiskit_nature/second_q/operators/bosonic_op.py --------- Co-authored-by: Steve Wood <[email protected]>
* Update black * Fix copyright
* Add MajoranaOp class * New style of MajoranaOp.terms(), some new tests * Update majorana_op.py * Update majorana_op.py * Some easier reviews done. More will follow. * Update releasenotes/notes/add-majoranaop-1cbf9d4a1d4c264e.yaml Co-authored-by: Max Rossmannek <[email protected]> * Update releasenotes/notes/add-majoranaop-1cbf9d4a1d4c264e.yaml Co-authored-by: Max Rossmannek <[email protected]> * Update qiskit_nature/second_q/operators/majorana_op.py Co-authored-by: Max Rossmannek <[email protected]> * Reviewed changes * final suggestions by mrossinek * release notes: added example * suggestions from pylint for tests to pass * Fixed copyright header for modified files --------- Co-authored-by: Max Rossmannek <[email protected]> Co-authored-by: Steve Wood <[email protected]> Co-authored-by: Max Rossmannek <[email protected]>
* Implement ModeBasedMapper no caching * Added caching and release note * Update release note to pass spell check * fix typing * fix typing for Python <3.10 * suggestions by mrossinek plus changes needed to pass pylint * Update improve-mappers-b55cb0ca5fd656e4.yaml --------- Co-authored-by: Steve Wood <[email protected]> Co-authored-by: Max Rossmannek <[email protected]>
* Added bosonic log mapper * Created mapper tests. Fixes in algorithm * Added annihilation operator tests. Fixes in algo * Added more unit tests * Added more unit tests * Style fixes. Added documentation * Added release note * CI fixes * Further CI fixes * Apply suggestions from code review Co-authored-by: Max Rossmannek <[email protected]> * PR fixes * Style fixes * Style fix * Some phrasing from PR review Co-authored-by: Max Rossmannek <[email protected]> * Refactor of single qubit op mapping * Added missing unit tests * Added bosonic log mapper * Created mapper tests. Fixes in algorithm * Added annihilation operator tests. Fixes in algo * Added more unit tests * Added more unit tests * Style fixes. Added documentation * Added release note * CI fixes * Further CI fixes * Apply suggestions from code review Co-authored-by: Max Rossmannek <[email protected]> * PR fixes * Style fixes * Style fix * Some phrasing from PR review Co-authored-by: Max Rossmannek <[email protected]> * Refactor of single qubit op mapping * Added missing unit tests * Fixed typo * Doc fixes from code review Co-authored-by: Max Rossmannek <[email protected]> * Raise error instead of break statement * Minor fix --------- Co-authored-by: Max Rossmannek <[email protected]>
…iskit-community#1374) * Fixed pylint warnings * Fixed mypy errors * Fixed errors in tests due to old package networkx * Copyright and style fixes * Updated contribution guidelines * Removed unused type ignore comment * Added transpiler to pylintdict * debug macos pipeline * Test using macos 13 * Test with macos12 * Test setup conda * Dropped python 3.9 support * Copyright fix * Added debug for psi4 * install libecpint for psi4 on ubuntu for python 3.9 and 3.10 * Sintax error fix * Fixed logic for libecpint installation * Removed python 3.8 folders * Fixed mergify yml * Added release note for python 3.8 drop * Removed unnecessary package from requirements-decv
…ture into mixedop/base
Pull Request Test Coverage Report for Build 13037067360Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #795
This draft PR introduces a MixedOp for manipulating systems corresponding to various "local" Hilbert spaces.
An implementation of the MixedMapper for mapping this operator into a sum of qubit operators acting on the composed registers is also proposed.
Updated tutorial
MixedOpTutorial.zip