-
-
Notifications
You must be signed in to change notification settings - Fork 40.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for out-of-tree userspace #11269
Conversation
Thank you for your contribution! |
@Erovia I'm highly interested in your PR, would you mind rebasing it against master please ? |
Has some merge conflicts here. |
@@ -0,0 +1,69 @@ | |||
# External Userspace: Store your code outside the QMK repo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it make sense to also document how to use this with plain make
invocations?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think so.
While it can be used with make
, absolutely... the overall goal is to remove the dependency on make
as much as possible, and push everyone to qmk
.
Because of that, I don't think that adding documentation for make, well, makes any sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok!
Also, merge conflicts |
I really like the doctor refactor bit. Does it make sense to extract that into its own PR? |
We actually refactored doctor.py pretty recently in #13298, it will land in master with the next develop merge. |
Has conflicts, removing the labels preventing stalebot from closing this automatically. |
Converted to draft to prevent accidental merge. |
Thank you for your contribution! |
Thank you for your contribution! |
Description
Allow users to use out-of-tree keymaps/layouts.
Set the absolute path with
qmk config user.userspace=/path/to/external/userspace
and useqmk compile
as usual.TODO:
DocumentationOpened as draft to get feedback and maybe help with writing the documentation.Types of Changes
Issues Fixed or Closed by This PR
Checklist