Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move matrix config to info.json, part 5 #20003

Merged
merged 5 commits into from
Mar 10, 2023

Conversation

fauxpark
Copy link
Member

@fauxpark fauxpark commented Mar 3, 2023

Description

#20001

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Copy link
Member

@tzarc tzarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now there are two identified problems, one of them probably because it was migrated elsewhere.

Also, for some reason studiokestra/galatea/rev1:default fails to build after merge, too:

Linking: .build/studiokestra_galatea_rev1_default.elf                                               [ERRORS]
 |
 | /usr/lib/gcc/avr/12.1.0/../../../../avr/bin/ld: .build/obj_studiokestra_galatea_rev1_default/quantum/action.o: in function `process_action':
 | /home/nickb/qmk_build/sha1_verification/qmk_firmware_pr/quantum/action.c:585: undefined reference to `layer_state_set'
 | collect2: error: ld returned 1 exit status
 |
make[1]: *** [builddefs/common_rules.mk:267: .build/studiokestra_galatea_rev1_default.elf] Error 1
Make finished with errors

keyboards/skme/zeno/info.json Outdated Show resolved Hide resolved
@tzarc tzarc merged commit e933e04 into qmk:develop Mar 10, 2023
@fauxpark fauxpark deleted the matrix-pins-data-driven-5 branch March 10, 2023 18:45
coquizen pushed a commit to coquizen/qmk_firmware that referenced this pull request Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants