Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce test BOM #496

Closed
ppalaga opened this issue Aug 17, 2022 · 1 comment · Fixed by #503
Closed

Introduce test BOM #496

ppalaga opened this issue Aug 17, 2022 · 1 comment · Fixed by #503
Assignees
@ppalaga
Milestone
1.5.0

Comments

@ppalaga
Copy link
Contributor

ppalaga commented Aug 17, 2022

A followup of the discussion in #488 (comment)

Much like Quarkus has its quarkus-bom-test we could also introduce a new module called quarkus-cxf-bom-test to manage dependencies useful for testing of Quarkus CXF applications.

org.apache.cxf:cxf-rt-transports-http-netty-server would be a good candidate for adding into a new test BOM.
@ppalaga ppalaga mentioned this issue Aug 17, 2022
Merged
@famod
Copy link
Contributor

famod commented Aug 17, 2022

To quote myself from the references comment:

quarkus-cxf-bom-test makes sense!

IMO, the first release that contains this change (this PR) has to ship such a test bom as well, otherwise we'd be back to the pre-BOM state as far as that netty artifact is concerned, making it a bit of a breaking change.

@ppalaga ppalaga self-assigned this Aug 17, 2022
ppalaga added a commit to ppalaga/quarkus-cxf that referenced this issue Aug 22, 2022
@ppalaga
Introduce test BOM quarkiverse#496
787189b
@ppalaga ppalaga mentioned this issue Aug 22, 2022
Merged
ppalaga added a commit that referenced this issue Aug 22, 2022
@ppalaga
Introduce test BOM #496
59b1579
@ppalaga ppalaga added this to the 1.5.0 milestone Sep 7, 2022
ppalaga added a commit to ppalaga/quarkus-cxf that referenced this issue Dec 1, 2022
@ppalaga
Fixup quarkiverse#496 cxf-rt-transports-http-netty-server is supposed…
9013c7f 
… to be present only in the test BOM. not in the main BOM. It is not present in the flattened main BOM anyway
ppalaga added a commit to ppalaga/quarkus-cxf that referenced this issue Dec 1, 2022
@ppalaga
Fixup quarkiverse#496 cxf-rt-transports-http-netty-server is supposed…
9bcb65c 
… to be present only in the test BOM. not in the main BOM. It is not present in the flattened main BOM anyway
ppalaga added a commit that referenced this issue Dec 1, 2022
@ppalaga
Fixup #496 cxf-rt-transports-http-netty-server is supposed to be pres…
4725332 
…ent only in the test BOM. not in the main BOM. It is not present in the flattened main BOM anyway
ppalaga added a commit that referenced this issue Dec 1, 2022
@ppalaga
Fixup #496 cxf-rt-transports-http-netty-server is supposed to be pres…
4d3f207 
…ent only in the test BOM. not in the main BOM. It is not present in the flattened main BOM anyway
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ppalaga ppalaga

Labels
None yet
Projects
None yet
Milestone
1.5.0
Development

Successfully merging a pull request may close this issue.

Test WS Security server, fix related issues ppalaga/quarkus-cxf
2 participants
@ppalaga @famod