Multiple test modules

[ppalaga]

The ultimate goal is to have multiple test modules which would separately cover various aspects of Quarkus CXF:

• WS Server (done, but the module is still called basic)
• WS Client (done)
• WS Security (TODO: Test WS Security client #498 )

and possibly more. Having those in separate Maven modules is important because each use case may require different set of dependencies.

[ppalaga]

If somebody could please pre-approve this so that I can see that my changes work on the CI.

[shumonsharif]

Hey @ppalaga So I attempted to get you added to the project on #489 - but it didn't work. I believe we'll need at least one successfully merged PR from you, before that'll kick in, or maybe it's a permission issue.

@gastaldi Any thoughts on this?

[gastaldi]

@shumonsharif I noticed that it doesn't work if the comment is the first in the issue. You can add a new comment there with the same text and the all contributors bot should be triggered

[gastaldi]

BTW you can use that comment anywhere (even here), no need to create a specific issue

[gastaldi]

Also adding as a contributor with @all-contributors doesn't warrant CI runs, you're right that a PR needs to be merged to bypass that

[shumonsharif]

Thanks @gastaldi for your help! Just got home from a long walk, here goes ...

@all-contributors add @ppalaga for code

[allcontributors]

@shumonsharif

I've put up a pull request to add @ppalaga! 🎉

[shumonsharif]

@ppalaga @gastaldi @famod If you all are ok with it, I would like to propose giving @ppalaga maintainer status?

[gastaldi]

@shumonsharif that is a great idea. Mind opening a PR changing https://github.com/quarkiverse/quarkiverse-devops/blob/main/quarkus-cxf.tf?

[shumonsharif]

@shumonsharif that is a great idea. Mind opening a PR changing https://github.com/quarkiverse/quarkiverse-devops/blob/main/quarkus-cxf.tf?

@ppalaga Are you ok with this? Just wanted to get your permission before I put together the PR. I believe @famod is still on vacation, so I can go ahead if you provide a thumbs up.

[famod]

I might be able to have a look at this today evening but don't hold your breath. 😉

[ppalaga]

If you all are ok with it, I would like to propose giving @ppalaga maintainer status?

That would be great, thanks for your trust!

[famod]

LGTM overall! 👍

[famod]

Nitpick: Why not -f integration-tests?

[ppalaga]

cd tends to be safer for some buggy plugins (e.g. assuming that Paths.get(".") always returns ${basedir}). Maybe we do not have any such here.

[famod]

We probably don't but in the end I don't mind cd.

[ppalaga]

Rebased on top of the recent #487 and added some test refactoring commits.

[ppalaga]

• Rebased on top of the current master
• Changed the description of this PR to match the content
• Ready for review

[ppalaga]

Would anybody like to review?
The sooner the better. I am working on further changes.

[shumonsharif]

LGTM, @ppalaga !