Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove quarkus-opentelemetry-exporter-otlp and fix traces operation name in one module #366

Closed
wants to merge 2 commits into from

Conversation

michalvavrik
Copy link
Member

@michalvavrik michalvavrik commented Mar 2, 2023

I'm also aware there is issue with traces operation name in module 301, but I will address it in a separate PR as I'm having issue to run these tests at all (I hit serialization problems).

@pjgg pjgg self-requested a review March 3, 2023 07:50
@pjgg
Copy link
Contributor

pjgg commented Mar 3, 2023

Remove quarkus-opentelemetry-exporter-otlp itś fine because is included on quarkus-opentelemetry by default but we have to understand why neo4j is not resolved

@michalvavrik michalvavrik changed the title Remove quarkus-opentelemetry-exporter-otlp and neo4j deps to compilation Remove quarkus-opentelemetry-exporter-otlp as it was relocated to quarkus-opentelemetry Mar 3, 2023
@michalvavrik michalvavrik requested a review from pjgg March 3, 2023 09:03
@michalvavrik michalvavrik changed the title Remove quarkus-opentelemetry-exporter-otlp as it was relocated to quarkus-opentelemetry Remove quarkus-opentelemetry-exporter-otlp and fix traces operation name in one module Mar 3, 2023
@michalvavrik michalvavrik requested a review from fedinskiy March 3, 2023 13:11
@michalvavrik
Copy link
Member Author

Hmm, now that I think of it. CI will fail anyway as I didn't handle 301 module. I'll make it draft then.

@michalvavrik michalvavrik marked this pull request as draft March 3, 2023 13:13
@michalvavrik
Copy link
Member Author

@fedinskiy said he will investigate daily failures and open his own PR.

@michalvavrik michalvavrik deleted the feature/fix-deps branch March 6, 2023 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants