Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to OpenTelemetry v1.23.1 and smallrye-reactive-messaging to v4.4.0 #31356

Merged
merged 1 commit into from
Mar 3, 2023
Merged

Upgrade to OpenTelemetry v1.23.1 and smallrye-reactive-messaging to v4.4.0 #31356

merged 1 commit into from
Mar 3, 2023

Conversation

brunobat
Copy link
Contributor

@brunobat brunobat commented Feb 22, 2023 •
edited
Loading

SDK version had a minor fix.
Getters and setters semantic changes.
Semantic conventions changed, most prominently the span name. Now: Method + Route
Includes upgrade for smallrye-reactive-messaging v 4.4.0
Disable MP Telemetry TCK because it's not compatible with this OTel version.

@quarkus-bot quarkus-bot bot added area/dependencies Pull requests that update a dependency file area/tracing labels Feb 22, 2023
@quarkus-bot
Copy link

quarkus-bot bot commented Feb 22, 2023

/cc @radcortez (opentelemetry)

@brunobat brunobat changed the title Upgrade to OpenTelemetry v1.23.1 Upgrade to OpenTelemetry v1.23.1 and smallrye-reactive-messaging to v4.4.0 Mar 1, 2023
@brunobat brunobat marked this pull request as ready for review March 1, 2023 10:54
@brunobat brunobat requested review from radcortez and ozangunalp March 1, 2023 10:54
radcortez
radcortez approved these changes Mar 1, 2023
View reviewed changes
Copy link
Member

@radcortez radcortez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh boy.... OTel really likes to break stuff.

I wonder if we should point in our release notes the Span Name changes.

@brunobat
Copy link
Contributor Author

brunobat commented Mar 1, 2023

We need to... :(

@quarkus-bot

This comment has been minimized.

Sign in to view
@michalvavrik michalvavrik mentioned this pull request Mar 2, 2023
Merged
@quarkus-bot
Copy link

quarkus-bot bot commented Mar 2, 2023

Failing Jobs - Building 56f5296

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
⌛ JVM Tests - JDK 11 Windows Build ⚠️ Check → Logs Raw logs
✔️ JVM Tests - JDK 17
✔️ JVM Tests - JDK 19
✔️ Maven Tests - JDK 11
⌛ Maven Tests - JDK 11 Windows Build ⚠️ Check → Logs Raw logs
⌛ MicroProfile TCKs Tests Verify ⚠️ Check → Logs Raw logs
⌛ Native Tests - Data1 Build ⚠️ Check → Logs Raw logs

@brunobat brunobat merged commit 8982d17 into quarkusio:main Mar 3, 2023
@quarkus-bot quarkus-bot bot added this to the 3.0 - main milestone Mar 3, 2023
This was referenced Mar 3, 2023
Merged
Closed
Merged
@brunobat brunobat deleted the bump-otel-1-23 branch August 21, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ozangunalp ozangunalp ozangunalp approved these changes

@radcortez radcortez radcortez approved these changes

Assignees
No one assigned
Labels
area/dependencies Pull requests that update a dependency file area/reactive-messaging area/tracing release/breaking-change
Projects
None yet
Milestone
3.0.0.Alpha5
Development

Successfully merging this pull request may close these issues.
3 participants
@brunobat @ozangunalp @radcortez