-
Notifications
You must be signed in to change notification settings - Fork 21
Tests for multiple client access to the Infinispan cluster #196
Conversation
Hi @mjurc, this PR is now ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code seems to be okay, the utility classes and deployments do what they are supposed to do.
@mirostary Now that we have multitude of non-trivial scenarios in this test case, would you kindly add some simple summary to each test what the test does and where the assertions come from?
@mjurc I wrote a simple description of all tests and methods and I also disable the 7th test for now because of the issue (quarkusio/quarkus#15816). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mirostary Thanks for the fixes!
There is one more thing however, I realised. We need to have the switch to run the unit tests for those modules in GitHub actions. Please add those and once the new actions pass, this will be ready for merge.
run tests |
@mjurc |
run tests |
@mirostary Yes! |
Update the README to include info about Shouldn't be the RHDG tests using Do we have tests for upstream ISPN? |
also pls rebase to pick #246 changes |
done
No, only tests related to Openshift Datagrid Operator Still, some failed checks here... I don't know why JVM build action is failing. According to this https://main-jenkins-csb-quarkusqe.cloud.paas.psi.redhat.com/job/openshift-test-suite-ci/433/, at least the "Run OpenShift Tests Suite in JVM" should be ok. |
run tests |
…, readme, adding the @OnlyIfConfigured annotation and added the hotrod-client.properties file for the 7th test.
@mjurc @rsvoboda |
@mjurc what's the eta for review of this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requested changes implemented.
CI passed:
https://main-jenkins-csb-quarkusqe.cloud.paas.psi.redhat.com/job/openshift-test-suite-ci/483/
https://main-jenkins-csb-quarkusqe.cloud.paas.psi.redhat.com/job/openshift-test-suite-native-ci/344/
@mirostary Thanks for implementation. Kindly backport this coverage to 1.11 branch as well, thanks.
Changes:
3 more tests for multiple access: