Skip to content
This repository has been archived by the owner on Sep 18, 2023. It is now read-only.

Tests for multiple client access to the Infinispan cluster #196

Merged
merged 2 commits into from
Apr 21, 2021
Merged

Tests for multiple client access to the Infinispan cluster #196

merged 2 commits into from
Apr 21, 2021

Conversation

mirostary
Copy link
Contributor

@mirostary mirostary commented Feb 17, 2021

Changes:

  • For better readability created an abstract test class that separated test deployment settings and used methods from the actual tests
  • Increased Infinispan cluster allocated resources for better stability during restarts
  • Second client is copied from the openshift.yml file and deployed with a different name by another YAML file
  • Updated readme

3 more tests for multiple access:

  • simple connect to the second client
  • updating counters
  • connecting back after Datagrid restart

@mirostary
Copy link
Contributor Author

Hi @mjurc, this PR is now ready for review.
I'm just investigating one more issue which sometimes appears in the cache counter.

@mirostary mirostary marked this pull request as ready for review February 22, 2021 13:26
@mjurc mjurc self-requested a review March 14, 2021 19:39
Copy link
Member

@mjurc mjurc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code seems to be okay, the utility classes and deployments do what they are supposed to do.

@mirostary Now that we have multitude of non-trivial scenarios in this test case, would you kindly add some simple summary to each test what the test does and where the assertions come from?

Base automatically changed from master to main March 17, 2021 08:14
@mirostary
Copy link
Contributor Author

@mjurc I wrote a simple description of all tests and methods and I also disable the 7th test for now because of the issue (quarkusio/quarkus#15816).

Copy link
Member

@mjurc mjurc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mirostary Thanks for the fixes!

There is one more thing however, I realised. We need to have the switch to run the unit tests for those modules in GitHub actions. Please add those and once the new actions pass, this will be ready for merge.

@Sgitario
Copy link
Contributor

run tests

@mirostary
Copy link
Contributor Author

@mjurc
oh, you mean to add -Dinclude.datagrid switch to the https://github.com/quarkus-qe/quarkus-openshift-test-suite/blob/main/.github/workflows/ci.yml. Am I right?

@Sgitario
Copy link
Contributor

run tests

@mjurc
Copy link
Member

mjurc commented Mar 22, 2021

@mjurc
oh, you mean to add -Dinclude.datagrid switch to the https://github.com/quarkus-qe/quarkus-openshift-test-suite/blob/main/.github/workflows/ci.yml. Am I right?

@mirostary Yes!

@rsvoboda
Copy link
Member

rsvoboda commented Mar 24, 2021

Update the README to include info about include.datagrid flag!

Shouldn't be the RHDG tests using @OnlyIfConfigured("ts.authenticated-registry") ?

Do we have tests for upstream ISPN?

@rsvoboda
Copy link
Member

also pls rebase to pick #246 changes

@mirostary
Copy link
Contributor Author

mirostary commented Mar 25, 2021

Update the README to include info about include.datagrid flag!

Shouldn't be the RHDG tests using @OnlyIfConfigured("ts.authenticated-registry") ?

done

Do we have tests for upstream ISPN?

No, only tests related to Openshift Datagrid Operator

Still, some failed checks here... I don't know why JVM build action is failing. According to this https://main-jenkins-csb-quarkusqe.cloud.paas.psi.redhat.com/job/openshift-test-suite-ci/433/, at least the "Run OpenShift Tests Suite in JVM" should be ok.

@rsvoboda
Copy link
Member

run tests

…, readme, adding the @OnlyIfConfigured annotation and added the hotrod-client.properties file for the 7th test.
@mirostary
Copy link
Contributor Author

mirostary commented Apr 1, 2021

@mjurc @rsvoboda
According to the comment in QUARKUS-876, I removed the "@ Disabled" annotation and created the hotrod-client.properties for reducing the time when an application is trying to connect to the failed server. This PR is ready to review/merge.

@rsvoboda
Copy link
Member

@mjurc what's the eta for review of this PR?

Copy link
Member

@mjurc mjurc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mjurc mjurc merged commit cb1044e into quarkus-qe:main Apr 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants