Skip to content
This repository has been archived by the owner on Sep 18, 2023. It is now read-only.

[1.11] Update of infinispan-client module tests #270

Merged
merged 2 commits into from
May 14, 2021

Conversation

mirostary
Copy link
Contributor

Changes are the same as in merged PR 196

  • An abstract test class that separated test deployment settings and used methods from the actual tests
  • Increased Infinispan cluster allocated resources for better stability during restarts
  • Second client is copied from the openshift.yml file and deployed with a different name by another YAML file
  • 3 more tests for multiple access:
    - simple connect to the second client
    - updating counters
    - connecting back after Datagrid restart

@rsvoboda rsvoboda changed the title Update of infinispan-client module tests [1.11] Update of infinispan-client module tests Apr 26, 2021
@rsvoboda rsvoboda requested a review from mjurc April 26, 2021 09:49
@mjurc
Copy link
Member

mjurc commented May 3, 2021

Run tests

@rsvoboda
Copy link
Member

rsvoboda commented May 3, 2021

@mirostary Changes are not the same as in merged PR 196, please provide the reasoning / adjust the missing parts
(README / infinispan-client/src/main/resources/META-INF/hotrod-client.properties)

@rsvoboda
Copy link
Member

rsvoboda commented May 3, 2021

CI didn't pass, please investigate what went wrong.

@mirostary
Copy link
Contributor Author

mirostary commented May 5, 2021

Hi @rsvoboda @mjurc
I adjusted the missing readme and investigated why the CI is failing. It is because of this issue - quarkusio/quarkus#15487
It is ok in Quarkus version 1.11.6.Final (the commit is reverted in this version), but in 1.11.5.Final this module is failing along with some others modules.

Is there any plan to move to another version on this branch?

@rsvoboda
Copy link
Member

rsvoboda commented May 5, 2021

Create new commit as part of this PR to move to 1.11.6.Final

@mirostary
Copy link
Contributor Author

Run tests

1 similar comment
@mirostary
Copy link
Contributor Author

Run tests

@mirostary
Copy link
Contributor Author

According to JVM CI check, the infinispan-client module is working fine with the Quarkus version 1.11.6.Final. The only failing module is Deployment Strategies Serverless.

@rsvoboda
Copy link
Member

rsvoboda commented May 8, 2021

@mjurc please do the final check

@mjurc
Copy link
Member

mjurc commented May 14, 2021

CI passed - merging

@mjurc mjurc merged commit 4b535ca into quarkus-qe:1.11 May 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants