Skip to content
This repository has been archived by the owner on Sep 18, 2023. It is now read-only.

[WIP] - Quarkus 2.x Upgrade #271

Closed
wants to merge 1 commit into from
Closed

Conversation

pjgg
Copy link
Contributor

@pjgg pjgg commented Apr 26, 2021

Enhancements:

  • Upgrade to Java 11
  • Upgrade to Quarkus 2.x
  • Remove quarkus-universe-bom from pom file
  • Remove avro-maven-plugin
  • quarkus.http.redirect-to-non-application-root-path was removed and there is no more non-app endpoints redirections

Code-style

  • missing io.quarkus:quarkus-ide-config:2.0.0.Alpha1 dependency

@pjgg pjgg changed the title Quarkus 2.x Upgrade [WIP] - Quarkus 2.x Upgrade Apr 26, 2021
@Sgitario
Copy link
Contributor

I think we should create a branch "1.13" before merging this PR.

@rsvoboda
Copy link
Member

@Sgitario why do we need 1.13 branch? There won't be any product based on 1.13.

@Sgitario
Copy link
Contributor

@Sgitario why do we need 1.13 branch? There won't be any product based on 1.13.

Just to keep a branch where the previous changes before Quarkus 2.0. We can also see the git history.

@rsvoboda
Copy link
Member

I think git history is enough

@pjgg pjgg force-pushed the feat/upgrade_2x branch 2 times, most recently from 15e7d2f to 4467e97 Compare April 29, 2021 15:23
@pjgg
Copy link
Contributor Author

pjgg commented Apr 29, 2021

I think git history is enough

I agree, I think that we could remove branch 1.13 and rely on the git history.

Copy link
Member

@rsvoboda rsvoboda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strimzi/Kafka - Fixed on upstream means latest Quarkus main?

Remove avro-maven-plugin ... why?

@pjgg pjgg force-pushed the feat/upgrade_2x branch from 31c56ba to 3e0f3d0 Compare May 14, 2021 08:31
@pjgg
Copy link
Contributor Author

pjgg commented May 14, 2021

Strimzi/Kafka - Fixed on upstream means latest Quarkus main?

Remove avro-maven-plugin ... why?

  • Kafka/strimzi fixed on 2.0.0.Alpha2
  • avro-maven-plugin -> is not required anymore, is integrated in quarkus-maven-plugin
<plugin>
     <groupId>io.quarkus</groupId>
     <artifactId>quarkus-maven-plugin</artifactId>
     <version>${version.plugin.quarkus}</version>
     <executions>
         <execution>
                <goals>
                    <goal>build</goal>
                     <goal>generate-code</goal>
               </goals>
         </execution>
     </executions>
</plugin>

You just need to add generate-code as a goal, and that is all!.

@pjgg pjgg force-pushed the feat/upgrade_2x branch 4 times, most recently from 2fedd89 to da67080 Compare May 17, 2021 09:19
@pjgg pjgg force-pushed the feat/upgrade_2x branch 6 times, most recently from fc08461 to 507427f Compare May 24, 2021 08:08
@pjgg pjgg force-pushed the feat/upgrade_2x branch 2 times, most recently from 02b1739 to 3fcf675 Compare June 1, 2021 16:11
@pjgg pjgg force-pushed the feat/upgrade_2x branch from 3fcf675 to 92f55de Compare June 1, 2021 16:20
@pjgg
Copy link
Contributor Author

pjgg commented Jul 19, 2021

moved to: #312

@pjgg pjgg closed this Jul 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants