Skip to content
This repository was archived by the owner on Sep 18, 2023. It is now read-only.

Quarkus 2.0.2.Final Upgrade #312

Merged
merged 1 commit into from
Jul 21, 2021
Merged

Conversation

pjgg
Copy link
Contributor

@pjgg pjgg commented Jul 19, 2021

  • Openshift Service default port has moved from 8080 to 80
  • HtmlUnit lib has removed from universe bom
  • Non-application endpoint doesn't do a redirection anymore
  • io.quarkus.grpc.runtime.annotations.GrpcService annotation was renamed to io.quarkus.grpc.GrpcClient
  • Vert.x4: some references as io.vertx.core.http.HttpMethod are not available anymore
  • quarkus.openshift.expose property has been moved to quarkus.openshift.route.expose
  • Upgrade to Java 11
  • Remove avro-maven-plugin
  • @quarkus.security.Authenticated is not required anymore

@pjgg pjgg mentioned this pull request Jul 19, 2021
@pjgg pjgg force-pushed the feat/quarkus2_0_1 branch from 693f626 to b4207b2 Compare July 19, 2021 09:20
@pjgg pjgg requested a review from rsvoboda July 19, 2021 11:27
@rsvoboda
Copy link
Member

run tests

@rsvoboda
Copy link
Member

@pjgg are all the changes you needed to do covered in Quarkus migration guide so people can be aware of them ?

@rsvoboda rsvoboda requested a review from Sgitario July 20, 2021 08:40
@rsvoboda
Copy link
Member

Adding also Jose to double check this. Many files changed, but the number of changes is not high, just on many places.

@pjgg
Copy link
Contributor Author

pjgg commented Jul 20, 2021

@pjgg are all the changes you needed to do covered in Quarkus migration guide so people can be aware of them?

The changes are explained, but the impact of some of them is not easy to see. For example,

https://github.com/quarkusio/quarkus/wiki/Migration-Guide-2.0#legacy-redirect-for-non-application-endpoints-such-as-health

If your services export metrics to Prometheus you must create an OCP ServiceMonitor, for example:

apiVersion: monitoring.coreos.com/v1
kind: ServiceMonitor
metadata:
  labels:
    k8s-app: prometheus-app-monitor
  name: prometheus-app-monitor
spec:
  endpoints:
  - interval: 30s
    targetPort: 8080
    path: /q/metrics
    scheme: http
  selector:
    matchLabels:
      # Configured in application.properties: quarkus.openshift.labels.app-with-metrics
      app-with-metrics: 'quarkus-app'

This resource is not created by default by Quarkus so must be changed by the end user itself.
path: /metrics -> path: /q/metrics

Copy link
Contributor

@Sgitario Sgitario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some questions and one change that should be removed about the @Authenticated annotation.

<groupId>io.quarkus</groupId>
<artifactId>quarkus-junit5</artifactId>
<scope>test</scope>
</dependency>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did we need to add this dependency?

Copy link
Contributor Author

@pjgg pjgg Jul 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because this module require this other dependency org.junit.platform:junit-platform-launcher:jar:1.7.2:test that comes with io.quarkus:quarkus-junit5. Other modules are in the same situation but this one was the only one that didn't brings io.quarkus:quarkus-junit5

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How can I reproduce the issue you mention? I removed the quarkus-junit5 dependency and the test execution worked fine :/

@rsvoboda
Copy link
Member

The changes are explained, but the impact of some of them is not easy to see.

Please create issue(s) to enhance migration guide about the impact

@rsvoboda
Copy link
Member

Run OpenShift Tests Suite in JVM failed, please double check what went wrong

@pjgg pjgg force-pushed the feat/quarkus2_0_1 branch from b4207b2 to 13277c9 Compare July 20, 2021 11:04
@pjgg pjgg changed the title Quarkus 2.0.1.Final Upgrade Quarkus 2.0.2.Final Upgrade Jul 20, 2021
@pjgg
Copy link
Contributor Author

pjgg commented Jul 20, 2021

The changes are explained, but the impact of some of them is not easy to see.

Please create issue(s) to enhance migration guide about the impact

Issue Ref: quarkusio/quarkus#18855
I didn't see it! but the explanation is also there!.

@pjgg
Copy link
Contributor Author

pjgg commented Jul 20, 2021

Run OpenShift Tests Suite in JVM failed, please double-check what went wrong

We had several "Issues" but in my opinion, are all related to the environment.

For example:
Module: mssql
error: You must be logged in to the server (Unauthorized)

Module: Postgress
error: java.lang.RuntimeException: oc failed (executed [oc, new-project, ts-evvxawtsom], return code 1)

Module: MultiplePersistenceUnitIT
error: Failure executing: GET at: https://api.ocp46.dynamic.quarkus:6443/apis/apps.openshift.io/v1/namespaces/ts-elubatvvjx/deploymentconfigs/mariadb. Message: Unauthorized! Token may have expired! Please log-in again. Unauthorized.

Module: Infinispan
error: java.lang.IllegalArgumentException: DeploymentConfig with name:[infinispan-client] in namespace:[ts-fkkszfmnsf] matching condition not found!

Module: security Basic
Error: java.lang.RuntimeException: oc failed (executed [oc, apply, -f, target/kubernetes/openshift.yml]

All test has success yesterday in the same environment without code changes.

After these error I have validated locally (against the same ocp server) the following modules: Security Basic, Infinispan, mssql. All success.

@rsvoboda
Copy link
Member

Openshift Service default port has moved from 8080 to 80 - @pjgg what triggered that change ?

@pjgg
Copy link
Contributor Author

pjgg commented Jul 20, 2021

Openshift Service default port has moved from 8080 to 80 - @pjgg what triggered that change ?

Usability / developers experience. In the previous version, you need to know the service DNS and the port. Now all the services by default will expose their deployment through port 80

Issue ref: quarkusio/quarkus#13945

@pjgg pjgg force-pushed the feat/quarkus2_0_1 branch from 13277c9 to 87968be Compare July 20, 2021 16:22
- Openshift Service default port has moved from 8080 to 80
- HtmlUnit lib has removed from universe bom
- Non-application endpoint doesn't do a redirection anymore
- io.quarkus.grpc.runtime.annotations.GrpcService annotation was renamed to io.quarkus.grpc.GrpcClient
- Vert.x4: some references as io.vertx.core.http.HttpMethod are not available anymore
- `quarkus.openshift.expose` property has been moved to `quarkus.openshift.route.expose`
- Upgrade to Java 11
- Remove avro-maven-plugin
@pjgg pjgg force-pushed the feat/quarkus2_0_1 branch from 87968be to 05645fb Compare July 21, 2021 08:08
@rsvoboda
Copy link
Member

Sick of waiting for CI for 5 hours, merging.

@rsvoboda rsvoboda merged commit 31c40bd into quarkus-qe:main Jul 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants