-
Notifications
You must be signed in to change notification settings - Fork 21
Conversation
run tests |
@pjgg are all the changes you needed to do covered in Quarkus migration guide so people can be aware of them ? |
Adding also Jose to double check this. Many files changed, but the number of changes is not high, just on many places. |
The changes are explained, but the impact of some of them is not easy to see. For example, If your services export metrics to Prometheus you must create an OCP ServiceMonitor, for example:
This resource is not created by default by Quarkus so must be changed by the end user itself. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some questions and one change that should be removed about the @Authenticated
annotation.
<groupId>io.quarkus</groupId> | ||
<artifactId>quarkus-junit5</artifactId> | ||
<scope>test</scope> | ||
</dependency> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did we need to add this dependency?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because this module require this other dependency org.junit.platform:junit-platform-launcher:jar:1.7.2:test
that comes with io.quarkus:quarkus-junit5
. Other modules are in the same situation but this one was the only one that didn't brings io.quarkus:quarkus-junit5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How can I reproduce the issue you mention? I removed the quarkus-junit5
dependency and the test execution worked fine :/
...cloak-authz/src/main/java/io/quarkus/ts/openshift/security/keycloak/authz/AdminResource.java
Outdated
Show resolved
Hide resolved
...cloak-authz/src/main/java/io/quarkus/ts/openshift/security/keycloak/authz/AdminResource.java
Outdated
Show resolved
Hide resolved
...ycloak-authz/src/main/java/io/quarkus/ts/openshift/security/keycloak/authz/UserResource.java
Outdated
Show resolved
Hide resolved
...ycloak-authz/src/main/java/io/quarkus/ts/openshift/security/keycloak/authz/UserResource.java
Outdated
Show resolved
Hide resolved
Please create issue(s) to enhance migration guide about the impact |
Run OpenShift Tests Suite in JVM failed, please double check what went wrong |
Issue Ref: quarkusio/quarkus#18855 |
We had several "Issues" but in my opinion, are all related to the environment. For example: Module: Postgress Module: MultiplePersistenceUnitIT Module: Infinispan Module: security Basic All test has success yesterday in the same environment without code changes. After these error I have validated locally (against the same ocp server) the following modules: Security Basic, Infinispan, mssql. All success. |
|
Usability / developers experience. In the previous version, you need to know the service DNS and the port. Now all the services by default will expose their deployment through port 80 Issue ref: quarkusio/quarkus#13945 |
- Openshift Service default port has moved from 8080 to 80 - HtmlUnit lib has removed from universe bom - Non-application endpoint doesn't do a redirection anymore - io.quarkus.grpc.runtime.annotations.GrpcService annotation was renamed to io.quarkus.grpc.GrpcClient - Vert.x4: some references as io.vertx.core.http.HttpMethod are not available anymore - `quarkus.openshift.expose` property has been moved to `quarkus.openshift.route.expose` - Upgrade to Java 11 - Remove avro-maven-plugin
Sick of waiting for CI for 5 hours, merging. |
io.vertx.core.http.HttpMethod
are not available anymorequarkus.openshift.expose
property has been moved toquarkus.openshift.route.expose