Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix implementation of reactive URL in OracleService #503

Closed
jsmrcka opened this issue Jun 29, 2022 · 1 comment
Closed

Fix implementation of reactive URL in OracleService #503

jsmrcka opened this issue Jun 29, 2022 · 1 comment
Assignees
Labels
bug Something isn't working priority/high higher priority than moderate but lower than urgent

Comments

@jsmrcka
Copy link
Contributor

jsmrcka commented Jun 29, 2022

Current implementation

    @Override
    public String getReactiveUrl() {
        return getHost().replace("http://", getJdbcName() + ":thin:@") + ":" + getPort() + ":" + getDatabase();
    }

should be replaced with

    @Override
    public String getReactiveUrl() {
        return getHost().replace("http://", getJdbcName() + ":thin:@") + ":" + getPort() + "/" + getDatabase();
    }

(colon : replaced by slash /).

Proper syntax of reactive URL for Oracle DB is documented only partially.

An issue to clarify the topic: quarkusio/quarkus#26426.

As part of the implementation change, add test coverage for reactive URL.

Follow-up to:
#428
#489

@jsmrcka jsmrcka self-assigned this Jun 29, 2022
@pjgg pjgg added enhancement New feature or request priority/high higher priority than moderate but lower than urgent bug Something isn't working and removed enhancement New feature or request labels Aug 3, 2022
@michalvavrik
Copy link
Member

I checked all getReactiveUrl() and can't find any with that colon anymore, so I'll go ahead and close the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority/high higher priority than moderate but lower than urgent
Projects
None yet
Development

No branches or pull requests

3 participants