Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement reactive URL in OracleService #428

Merged
merged 1 commit into from
Apr 1, 2022

Conversation

jsmrcka
Copy link
Contributor

@jsmrcka jsmrcka commented Mar 10, 2022

Based on Reactive Oracle Client implementation:
quarkusio/quarkus#22810

Based on Reactive Oracle Client implementation:
quarkusio/quarkus#22810
@jsmrcka jsmrcka requested a review from mjurc March 10, 2022 14:05
@jsmrcka jsmrcka self-assigned this Mar 10, 2022
Copy link
Member

@mjurc mjurc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems legitimate - but can you add a reactive Oracle test to examples? Just so that we have test coverage for this feature on framework side too.

@rsvoboda
Copy link
Member

rsvoboda commented Apr 1, 2022

Separate issue was created for the example app. Going to merge this change.

@rsvoboda rsvoboda merged commit 8022abb into quarkus-qe:main Apr 1, 2022
@jsmrcka jsmrcka deleted the feat/oracle-reactive-url branch April 29, 2022 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants