Extend sql-db/hibernate-reactive and sql-db/vertx-sql with oracle
#563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsmrcka
force-pushed
the
QUARKUS-1407
branch
2 times, most recently
from
a4bb9dd to
0153940
Compare
jsmrcka
force-pushed
the
QUARKUS-1407
branch
2 times, most recently
from
470abd2 to
1d825e5
Compare
fedinskiy
requested changes
Apr 6, 2022
sql-db/hibernate-reactive/src/test/java/io/quarkus/ts/reactive/OracleDatabaseIT.java
Outdated
Show resolved
Hide resolved
jsmrcka
force-pushed
the
QUARKUS-1407
branch
2 times, most recently
from
545f201 to
a0a77c7
Compare
rsvoboda
approved these changes
Jun 29, 2022
fedinskiy
requested changes
Jun 29, 2022
sql-db/vertx-sql/src/test/java/io/quarkus/ts/vertx/sql/dbpool/PostgresPoolTest.java
Outdated
Show resolved
Hide resolved
sql-db/hibernate-reactive/src/test/java/io/quarkus/ts/hibernate/reactive/OracleDatabaseIT.java
Outdated
Show resolved
Hide resolved
sql-db/vertx-sql/src/main/java/io/quarkus/ts/vertx/sql/services/DbPoolService.java
Outdated
Show resolved
Hide resolved
Extend with reactive Oracle client. Implementation of test plan for QUARKUS-1407: https://github.com/quarkus-qe/quarkus-test-plans/blob/main/QUARKUS-1407.md
jsmrcka
added a commit
to jsmrcka/quarkus-test-suite
that referenced
this pull request
Jun 30, 2022
Resolved upstream issues: - quarkusio/quarkus#24501 - quarkusio/quarkus#24264 Follow-up to quarkus-qe#563.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend with reactive Oracle client.
Implementation of test plan for QUARKUS-1407:
https://github.com/quarkus-qe/quarkus-test-plans/blob/main/QUARKUS-1407.md
Related issues/PRs:
Implement reactive URL inCurrent implementation is outdated. New issues filed:OracleServicequarkus-test-framework#428 - Reactive URL for OracleService not yet implemented in TF.Figure out how to return last inserted ID from Oracle DB usingreactive-oracle-client#566 - Unresolved issue of returning last inserted ID from Oracle.OracleDatabaseIT#ensureSessionIsPropagatedOnReactiveTransactions- Test disabled, issue created: Reactive Oracle client fails session propagation test quarkusio/quarkus#24501sql-db/vertx-sql- native build disabled: Reactive Oracle client - native build fails quarkusio/quarkus#24788